Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11987
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-204079288
LGTM merging into master, thanks @gatorsmile and reviewers!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-204070716
@andrewor14 @yhuai Could you also check if the latest version is fine?
Thanks!
---
If your project is set up for it, you can reply to this email and have your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-204062440
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-204062439
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-204062050
**[Test build #54644 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54644/consoleFull)**
for PR 11987 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-204018880
**[Test build #54644 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54644/consoleFull)**
for PR 11987 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-204008841
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-204008836
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-204008475
**[Test build #54634 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54634/consoleFull)**
for PR 11987 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-203984639
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-203984634
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-203984404
**[Test build #54628 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54628/consoleFull)**
for PR 11987 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-203975432
**[Test build #54634 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54634/consoleFull)**
for PR 11987 at commit
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-203970490
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-203965085
One minor comment. LGTM pending jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11987#discussion_r58063615
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -510,16 +513,22 @@ class SparkSqlAstBuilder extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11987#discussion_r58062792
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -510,16 +513,22 @@ class SparkSqlAstBuilder extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-203956800
**[Test build #54628 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54628/consoleFull)**
for PR 11987 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11987#discussion_r58059334
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -253,6 +256,12 @@ case class AlterTableSkewedLocation(
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/11987#discussion_r58016427
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -271,6 +280,14 @@ case class AlterTableExchangePartition(
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/11987#discussion_r58016351
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -253,6 +256,12 @@ case class AlterTableSkewedLocation(
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-203794945
@andrewor14 @rxin Based on your comments, the latest commits removed all
the changes on the ANTLR3 codes, which will be removed soon. Now, the only
changes in this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-203793602
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-203793600
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-203793109
**[Test build #54598 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54598/consoleFull)**
for PR 11987 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-203773703
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-203773709
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-203772943
**[Test build #54592 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54592/consoleFull)**
for PR 11987 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-203772332
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-203772338
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-203771892
**[Test build #54594 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54594/consoleFull)**
for PR 11987 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-203764881
**[Test build #54598 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54598/consoleFull)**
for PR 11987 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11987#discussion_r58001426
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/ng/SqlBase.g4
---
@@ -74,12 +75,16 @@ statement
SET SKEWED
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/11987#discussion_r58001378
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/ng/SqlBase.g4
---
@@ -74,12 +75,16 @@ statement
SET SKEWED LOCATION
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11987#discussion_r58001379
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/ng/SqlBase.g4
---
@@ -74,12 +75,16 @@ statement
SET SKEWED
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-203751599
**[Test build #54594 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54594/consoleFull)**
for PR 11987 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-203750876
**[Test build #54592 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54592/consoleFull)**
for PR 11987 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11987#discussion_r57957119
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/ng/SqlBase.g4
---
@@ -102,6 +102,15 @@ statement
(PARTITIONED
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11987#discussion_r57956695
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/ng/SqlBase.g4
---
@@ -102,6 +102,15 @@ statement
(PARTITIONED
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11987#discussion_r57955099
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/ng/SqlBase.g4
---
@@ -102,6 +102,15 @@ statement
(PARTITIONED
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11987#discussion_r57946641
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/ng/SqlBase.g4
---
@@ -102,6 +102,15 @@ statement
(PARTITIONED
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-203540854
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-203540857
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-203540488
**[Test build #54528 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54528/consoleFull)**
for PR 11987 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-203492992
**[Test build #54528 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54528/consoleFull)**
for PR 11987 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11987#discussion_r57909477
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLCommandSuite.scala
---
@@ -389,21 +415,61 @@ class DDLCommandSuite extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11987#discussion_r57792823
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AlterTableAlterViewCommandParser.scala
---
@@ -29,22 +29,26 @@ import
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11987#discussion_r57792101
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AlterTableAlterViewCommandParser.scala
---
@@ -29,22 +29,26 @@ import
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11987#discussion_r57791722
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AlterTableAlterViewCommandParser.scala
---
@@ -29,22 +29,26 @@ import
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11987#discussion_r57791427
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AlterTableAlterViewCommandParser.scala
---
@@ -29,22 +29,26 @@ import
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11987#discussion_r57679227
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -249,8 +249,9 @@ private[sql] class SparkQl(conf: ParserConf =
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-202744066
Yeah, will use the new ANTLR4. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11987#discussion_r57679267
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLCommandSuite.scala
---
@@ -389,21 +415,61 @@ class DDLCommandSuite extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11987#discussion_r57679214
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -106,17 +105,20 @@ case class DropFunction(
isTemp:
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-202687275
I just merged https://github.com/apache/spark/pull/12015
Can you update to use the new ANTLR4 parser instead? We are going to remove
the ANTLR3 one in the next
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-202601642
@gatorsmile this looks pretty solid. Could you take a look at
https://github.com/apache/spark/pull/12011 and rebase against that? Let me know
if you need some
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11987#discussion_r57642753
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLCommandSuite.scala
---
@@ -389,21 +415,61 @@ class DDLCommandSuite extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11987#discussion_r57642548
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -106,17 +105,20 @@ case class DropFunction(
isTemp:
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11987#discussion_r57642374
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -249,8 +249,9 @@ private[sql] class SparkQl(conf: ParserConf =
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-202556372
@yhuai @andrewor14 @viirya Could you please review the code changes for
this PR? Thanks!
---
If your project is set up for it, you can reply to this email and have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-202028250
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-202028247
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-202027840
**[Test build #54286 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54286/consoleFull)**
for PR 11987 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11987#issuecomment-202013658
**[Test build #54286 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54286/consoleFull)**
for PR 11987 at commit
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/11987
[SPARK-14182] [SQL] Parse DDL Command: Alter View
What changes were proposed in this pull request?
This PR is to provide native parsing support for DDL commands: `Alter
View`. Since
66 matches
Mail list logo
