[GitHub] spark pull request: [SPARK-14204] [SQL] register driverClass rathe...

2016-05-29 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/12000#issuecomment-222398286 ping @JoshRosen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-14204] [SQL] register driverClass rathe...

2016-05-25 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/12000#issuecomment-221769197 @JoshRosen , could you merge this into branch-1.6? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-14204] [SQL] register driverClass rathe...

2016-05-17 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/12000#issuecomment-219890576 I'm on vacation right now. This patch seems pretty small and reasonable to me, though, so it would be great if someone else could take a final look and merge if

[GitHub] spark pull request: [SPARK-14204] [SQL] register driverClass rathe...

2016-05-16 Thread zzcclp
Github user zzcclp commented on the pull request: https://github.com/apache/spark/pull/12000#issuecomment-219626090 @mchalek @JoshRosen Is there any progress yet? I got the same error with spark-1.6.1. But if I add "driver=com.mysql.jdbc.Driver" property to write.jdbc's properties

[GitHub] spark pull request: [SPARK-14204] [SQL] register driverClass rathe...

2016-05-04 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12000#issuecomment-216899710 @JoshRosen do you have a thought on this since you made the change? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-14204] [SQL] register driverClass rathe...

2016-04-05 Thread mchalek
Github user mchalek commented on the pull request: https://github.com/apache/spark/pull/12000#issuecomment-205840895 Bump. Would be nice to get closure on this. I doubt that we were in the minority in being affected by this (although admittedly, complaints of other failures seem

[GitHub] spark pull request: [SPARK-14204] [SQL] register driverClass rathe...

2016-03-29 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/12000#issuecomment-203065118 There are some integration tests hosted in an separate repo by the Databricks people at https://github.com/databricks/spark-integration-tests , I'm not super sure on

[GitHub] spark pull request: [SPARK-14204] [SQL] register driverClass rathe...

2016-03-29 Thread mchalek
Github user mchalek commented on the pull request: https://github.com/apache/spark/pull/12000#issuecomment-203062954 Thanks @holdenk I agree about the value of a regression test for this. I'm not familiar with how Spark's regression testing works. Is there a mechanism through which

[GitHub] spark pull request: [SPARK-14204] [SQL] register driverClass rathe...

2016-03-29 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/12000#issuecomment-202995487 That seems like a pretty reasonable change, although it might be good to add a regression test. Maybe @davies or @JoshRosen can verify this patch for Jenkins? --- If

[GitHub] spark pull request: [SPARK-14204] [SQL] register driverClass rathe...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12000#issuecomment-202472162 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14204] [SQL] register driverClass rathe...

2016-03-28 Thread mchalek
GitHub user mchalek opened a pull request: https://github.com/apache/spark/pull/12000 [SPARK-14204] [SQL] register driverClass rather than user class This pull request fixes an issue in which cluster-mode executors fail to properly register a JDBC driver when the driver is provided