Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/12152#discussion_r63970293
--- Diff: core/src/main/java/org/apache/spark/VersionInfo.java ---
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/12152#discussion_r63969585
--- Diff: core/src/main/java/org/apache/spark/VersionInfo.java ---
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
Github user jodersky commented on a diff in the pull request:
https://github.com/apache/spark/pull/12152#discussion_r63969372
--- Diff: core/src/main/java/org/apache/spark/VersionInfo.java ---
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/12152#issuecomment-207461399
Sorry if that wasn't clear, the motivation is to more easily tie this to
automated continuous integration and deployment and to easily have
traceability.
P
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12152#issuecomment-207401452
What's the motivation for this change BTW? is it strictly to reduce
duplication?
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/12152#issuecomment-206567197
Ok, Sanket will try using the antrun method. If it can be reused between
mvn and sbt that would be easier from that perspective as well.
---
If your project is set
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/12152#issuecomment-206532565
> Perhaps the difference here is the jira should have been more detailed to
list out all of the things we wanted to get here rather then just the version.
Yes,
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/12152#issuecomment-206527111
So to me here the difference is shell scripts vs Java code. Unless you
know of an easier way with antrun to do the md5sum and get the git information?
All I really
Github user redsanket commented on the pull request:
https://github.com/apache/spark/pull/12152#issuecomment-205611695
@vanzin The idea was to make it pluggable to be used by other projects if
neccessary. If we do not want to have additional information regarding the
build it can be s
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/12152#issuecomment-205477046
I mean antrun to generate the properties file. I understand that the plugin
can do more and is written in Java, but that argument would be a lot stronger
if this were ac
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/12152#issuecomment-205475275
@vanzin can you clarify, you mean antrun + echo to generate the properties
file part or more?You still have to call the other commands to get the git
info, md5 in
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/12152#issuecomment-205448379
@tgravescs see my comment; using antrun + echo (or replace) would I think
cover the most important parts here. No need for a custom plugin.
---
If your project is set u
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/12152#issuecomment-205446822
the code was mostly borrowed from other apache projects (hadoop/storm).
There is a fair amount of code here but its not really that complex. one maven
plugin, one ve
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/12152#issuecomment-205425907
Woah! This is _way_ too complex in its current form.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/12152#issuecomment-205398199
The custom plugin definitely looks like overkill. Can't you do something
close to this using the `antrun` plugin and the `echo` task?
Also, you'd have to change
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12152#issuecomment-205370758
This looks like a ton of complexity, with custom plugins and generated
files. What problem is this solving in comparison? The JIRA doesn't say why.
---
If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12152#issuecomment-205354825
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
GitHub user redsanket opened a pull request:
https://github.com/apache/spark/pull/12152
[SPARK-14279] Spark Version will be picked from pom.version
## What changes were proposed in this pull request?
This PR proposes to pick the version information for SPARK from pom.version.
18 matches
Mail list logo
