Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12128
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user yongtang commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-207847079
Thanks @yhuai. The pull request has been rebased and passed the Jenkins.
Please let me know if there are any other issues.
---
If your project is set up for it, you c
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-207842009
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-207842013
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-207841753
**[Test build #55436 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55436/consoleFull)**
for PR 12128 at commit
[`4c59c81`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-207823843
**[Test build #55436 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55436/consoleFull)**
for PR 12128 at commit
[`4c59c81`](https://gi
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-207818229
@yongtang This PR looks good to me. Can you rebase?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-205868721
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-205868723
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-205868179
**[Test build #54986 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54986/consoleFull)**
for PR 12128 at commit
[`927272c`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-205824874
**[Test build #54986 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54986/consoleFull)**
for PR 12128 at commit
[`927272c`](https://gi
Github user yongtang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12128#discussion_r58543563
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -213,8 +213,8 @@ class SQLQuerySuite extends QueryTest wit
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12128#discussion_r58492366
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -213,8 +213,8 @@ class SQLQuerySuite extends QueryTest w
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-205600527
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-205600525
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-205600511
**[Test build #54928 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54928/consoleFull)**
for PR 12128 at commit
[`353a132`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-205599127
**[Test build #54928 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54928/consoleFull)**
for PR 12128 at commit
[`353a132`](https://gi
Github user yongtang commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-205598731
Thanks @yhuai. The pull request has been updated. Please let me know if
there are any other issues.
---
If your project is set up for it, you can reply to this email
Github user yongtang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12128#discussion_r58476303
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -438,20 +438,38 @@ case class DescribeFunction(
}
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12128#discussion_r58475895
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -438,20 +438,38 @@ case class DescribeFunction(
}
Github user yongtang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12128#discussion_r58475784
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -438,20 +438,38 @@ case class DescribeFunction(
}
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12128#discussion_r58465327
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -438,20 +438,38 @@ case class DescribeFunction(
}
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-205519895
**[Test build #2743 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2743/consoleFull)**
for PR 12128 at commit
[`6e1e879`](https://
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-205482287
**[Test build #2743 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2743/consoleFull)**
for PR 12128 at commit
[`6e1e879`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-205387878
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-205387872
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-205387681
**[Test build #54855 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54855/consoleFull)**
for PR 12128 at commit
[`6e1e879`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-205342671
**[Test build #54855 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54855/consoleFull)**
for PR 12128 at commit
[`6e1e879`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-205182548
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-205182551
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-205182405
**[Test build #54834 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54834/consoleFull)**
for PR 12128 at commit
[`f318e8c`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-205173973
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-205173960
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-205173603
**[Test build #54829 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54829/consoleFull)**
for PR 12128 at commit
[`baad78f`](https://g
Github user yongtang commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-205159531
Hi @yhuai the pull request has been updated with the usages being added.
Let me know if there are any other issues. And thanks for the review.
---
If your project is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-205159077
**[Test build #54834 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54834/consoleFull)**
for PR 12128 at commit
[`f318e8c`](https://gi
Github user yongtang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12128#discussion_r58331883
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -438,20 +438,27 @@ case class DescribeFunction(
}
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12128#discussion_r58331592
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -438,20 +438,27 @@ case class DescribeFunction(
}
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-205149968
**[Test build #54829 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54829/consoleFull)**
for PR 12128 at commit
[`baad78f`](https://gi
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-205149524
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user yongtang commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-205149209
Hi @hvanhovell the pull request was updated. Let me know if there are any
issues.
---
If your project is set up for it, you can reply to this email and have your
repl
Github user yongtang commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-205053965
@hvanhovell Thanks. Let me take a look and update the pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-205051607
@yongtang can you see if you can hardcode the descriptions for the composed
function into the `DecribeFunction` command? See:
https://github.com/apache/spark/blob/ma
Github user yongtang commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-205039361
Hi @yhuai @hvanhovell , as a reference, below is the result of the
`describe function` for current master. I haven't been able to identify the
corresponding functions:
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-205034161
For composed expressions, if there are only a few of them, maybe we can
have special handling in the describe command? For `case`, we do not need to
support `describe fun
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-205024763
@yhuai what do you want to do with the composed expressions, i.e.: `!=`,
`<>` & `between`? `case` is more of a keyword.
---
If your project is set up for it, you c
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-204809902
**[Test build #2735 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2735/consoleFull)**
for PR 12128 at commit
[`7a84e9b`](https://
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-204804258
**[Test build #2735 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2735/consoleFull)**
for PR 12128 at commit
[`7a84e9b`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12128#issuecomment-204668180
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
GitHub user yongtang opened a pull request:
https://github.com/apache/spark/pull/12128
[SPARK-14335][SQL] Describe function command returns wrong output
## What changes were proposed in this pull request?
â¦because some of built-in functions are not in function registry.
50 matches
Mail list logo
