Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13079#discussion_r63710152
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,40 +626,149 @@ case class ShowCreateTableCommand(table:
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13079#discussion_r63669445
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,40 +626,149 @@ case class ShowCreateTableCommand(table:
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13079#discussion_r63620803
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -200,6 +207,7 @@ case class SimpleCatalogRelation(
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13079
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/13079#issuecomment-219878464
LGTM. I am merging this to master and 2.0. Let's change the error message
and exception class in a separate pr.
---
If your project is set up for it, you can reply to th
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13079#discussion_r63618404
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,40 +626,142 @@ case class ShowCreateTableCommand(table:
Tabl
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13079#discussion_r63570204
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,40 +626,149 @@ case class ShowCreateTableCommand(table:
Tabl
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13079#issuecomment-219784650
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13079#issuecomment-219784648
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13079#issuecomment-219784277
**[Test build #58697 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58697/consoleFull)**
for PR 13079 at commit
[`74fd5d3`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13079#issuecomment-219754482
**[Test build #58697 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58697/consoleFull)**
for PR 13079 at commit
[`74fd5d3`](https://gi
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13079#discussion_r63543727
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/ShowCreateTableSuite.scala ---
@@ -116,24 +116,143 @@ class ShowCreateTableSuite extends QueryT
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13079#discussion_r63543604
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,40 +626,142 @@ case class ShowCreateTableCommand(table:
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13079#discussion_r63489249
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,40 +626,142 @@ case class ShowCreateTableCommand(table:
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13079#discussion_r63489049
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,40 +626,142 @@ case class ShowCreateTableCommand(table:
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13079#discussion_r63488983
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -95,7 +101,8 @@ case class CatalogTable(
prope
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13079#discussion_r63489023
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,40 +626,142 @@ case class ShowCreateTableCommand(table:
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13079#discussion_r63488949
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,40 +626,142 @@ case class ShowCreateTableCommand(table:
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13079#discussion_r63414957
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/ShowCreateTableSuite.scala ---
@@ -116,24 +116,143 @@ class ShowCreateTableSuite extends QueryTest
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13079#discussion_r63412808
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,40 +626,142 @@ case class ShowCreateTableCommand(table:
Tabl
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13079#discussion_r63411416
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,40 +626,142 @@ case class ShowCreateTableCommand(table:
Tabl
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13079#discussion_r63394602
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -95,7 +101,8 @@ case class CatalogTable(
propertie
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13079#discussion_r63108319
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,40 +626,142 @@ case class ShowCreateTableCommand(table:
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13079#discussion_r63108270
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,40 +626,142 @@ case class ShowCreateTableCommand(table:
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13079#discussion_r63108155
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -95,7 +101,8 @@ case class CatalogTable(
prop
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13079#discussion_r63108072
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -338,6 +338,14 @@ private[hive] class HiveClientImpl(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13079#discussion_r63106023
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,40 +626,142 @@ case class ShowCreateTableCommand(table:
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13079#discussion_r63105981
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,40 +626,142 @@ case class ShowCreateTableCommand(table:
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13079#discussion_r63105572
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,40 +626,142 @@ case class ShowCreateTableCommand(table:
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13079#discussion_r63105105
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -79,6 +79,12 @@ case class CatalogTablePartition(
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13079#issuecomment-218849233
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13079#issuecomment-218849230
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13079#issuecomment-218848924
**[Test build #58504 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58504/consoleFull)**
for PR 13079 at commit
[`2020d77`](https://g
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13079#discussion_r63066039
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,40 +626,142 @@ case class ShowCreateTableCommand(table:
Ta
Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13079#discussion_r63065098
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -626,40 +626,142 @@ case class ShowCreateTableCommand(table:
Ta
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13079#issuecomment-218823528
**[Test build #58504 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58504/consoleFull)**
for PR 13079 at commit
[`2020d77`](https://gi
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/13079#issuecomment-218822204
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/13079#issuecomment-218803458
cc @yhuai @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
GitHub user liancheng opened a pull request:
https://github.com/apache/spark/pull/13079
[SPARK-14346][SQL] Native SHOW CREATE TABLE for Hive tables/views
## What changes were proposed in this pull request?
This is a follow-up of #12781. It adds native `SHOW CREATE TABLE` sup
39 matches
Mail list logo
