Github user jasonmoore2k commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-214658162
I've opened this ticket: https://issues.apache.org/jira/browse/SPARK-14915
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user jasonmoore2k commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-214651693
Previously, code was in place to treat a CDE in a particular way, but it
wasn't sufficient (it didn't consider that the CDE was actually nested inside a
Spark Exce
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-214636865
You know more about the semantics than I do, but does this change make the
behavior change in this way? it seems like just made something caused by a CDE
be handled like
Github user jasonmoore2k commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-214628237
@andrewor14 @srowen
I'm starting to think this change wasn't great to make. I'm now seeing
speculated tasks sometimes getting into a cycle of running, bei
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-207999135
SGTM; I checked for other instances of this pattern and I don't see any,
which is I suppose good news (didn't miss any) and bad (unfortunately don't get
to simply anythi
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12228
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-207932122
Merging into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-207607724
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-207607722
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-207607440
**[Test build #55381 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55381/consoleFull)**
for PR 12228 at commit
[`d5ebd55`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-207565637
**[Test build #55381 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55381/consoleFull)**
for PR 12228 at commit
[`d5ebd55`](https://gi
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-207565240
Fixed. retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12228#discussion_r59066989
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -321,7 +321,7 @@ private[spark] class Executor(
logInfo(s"Executor
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-207540334
Oh never mind, looks like Jenkins is broken at the moment:
https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Compile/job/spark-master-compile-maven-hadoop-2.3/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-207539353
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-207539352
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-207538976
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12228#discussion_r59065155
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -321,7 +321,7 @@ private[spark] class Executor(
logInfo(s"Exec
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12228#discussion_r59064976
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -321,7 +321,7 @@ private[spark] class Executor(
logInfo(s"Executor
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-207537481
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-207537478
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-207536042
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12228#discussion_r59063855
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -321,7 +321,7 @@ private[spark] class Executor(
logInfo(s"Exec
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12228#discussion_r59009601
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -321,7 +321,7 @@ private[spark] class Executor(
logInfo(s"Executor
Github user jasonmoore2k commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-207196510
@andrewor14, think it's safe to just retest? I don't think the fatal error
was because of these changes. I don't have the permissions to start a test
run.
---
Github user jasonmoore2k commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-207194131
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-207193145
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-207193142
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-207193064
**[Test build #55293 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55293/consoleFull)**
for PR 12228 at commit
[`d5ebd55`](https://g
Github user jasonmoore2k commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-207188334
Flaky test? The second test that is running has passed that one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-207184857
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-207184850
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-207184154
**[Test build #55288 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55288/consoleFull)**
for PR 12228 at commit
[`64a4499`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-207160003
**[Test build #55293 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55293/consoleFull)**
for PR 12228 at commit
[`d5ebd55`](https://gi
Github user jasonmoore2k commented on a diff in the pull request:
https://github.com/apache/spark/pull/12228#discussion_r58967842
--- Diff: core/src/test/scala/org/apache/spark/util/CausedBySuite.scala ---
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-207150989
**[Test build #55288 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55288/consoleFull)**
for PR 12228 at commit
[`64a4499`](https://gi
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12228#discussion_r58967525
--- Diff: core/src/test/scala/org/apache/spark/util/CausedBySuite.scala ---
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12228#discussion_r58967540
--- Diff: core/src/main/scala/org/apache/spark/util/CausedBy.scala ---
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-207150584
Looks great. Representing it in `unapply` is quite elegant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-207150346
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jasonmoore2k commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-206658369
Should the matching for FetchFailedException, TaskKilledException &
InterruptedException get similar treatment?
---
If your project is set up for it, you can repl
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12228#issuecomment-206658231
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
GitHub user jasonmoore2k opened a pull request:
https://github.com/apache/spark/pull/12228
[SPARK-14357] [CORE] Properly handle the root cause being a commit denied
exception
## What changes were proposed in this pull request?
When deciding whether a CommitDeniedException c
43 matches
Mail list logo
