Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12142
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12142#issuecomment-205479297
Ok merged into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12142#issuecomment-205410882
Looks good. This will break cases where the user has a class that listens
for Spark events but already extends some parent, but that's probably OK.
---
If your proj
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12142#issuecomment-205196536
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12142#issuecomment-205196533
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12142#issuecomment-205196174
**[Test build #54831 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54831/consoleFull)**
for PR 12142 at commit
[`4f4644d`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12142#issuecomment-205175834
**[Test build #2736 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2736/consoleFull)**
for PR 12142 at commit
[`7112bf2`](https://
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12142#issuecomment-205151632
**[Test build #54831 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54831/consoleFull)**
for PR 12142 at commit
[`4f4644d`](https://gi
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12142#discussion_r58331922
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/StatsReportListener.scala ---
@@ -0,0 +1,199 @@
+/*
+ * Licensed to the Apache Software Foundat
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12142#issuecomment-205151321
OK updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12142#discussion_r58331112
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala ---
@@ -249,6 +250,8 @@ trait SparkListener {
* Called when other events li
Github user ksakellis commented on the pull request:
https://github.com/apache/spark/pull/12142#issuecomment-205149044
Just that minor question but otherwise LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12142#discussion_r58330834
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala ---
@@ -249,6 +250,8 @@ trait SparkListener {
* Called when other events li
Github user ksakellis commented on a diff in the pull request:
https://github.com/apache/spark/pull/12142#discussion_r58330267
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala ---
@@ -249,6 +250,8 @@ trait SparkListener {
* Called when other even
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12142#issuecomment-205144472
**[Test build #2736 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2736/consoleFull)**
for PR 12142 at commit
[`7112bf2`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12142#issuecomment-205143712
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12142#issuecomment-205143679
**[Test build #54823 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54823/consoleFull)**
for PR 12142 at commit
[`7112bf2`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12142#issuecomment-205143714
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12142#issuecomment-205139815
**[Test build #54823 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54823/consoleFull)**
for PR 12142 at commit
[`7112bf2`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12142#issuecomment-205133324
**[Test build #54821 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54821/consoleFull)**
for PR 12142 at commit
[`05e4c5e`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12142#issuecomment-20516
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12142#issuecomment-20515
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12142#issuecomment-205131833
cc @JoshRosen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12142#issuecomment-205131573
**[Test build #54821 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54821/consoleFull)**
for PR 12142 at commit
[`05e4c5e`](https://gi
GitHub user rxin opened a pull request:
https://github.com/apache/spark/pull/12142
[SPARK-14358] Change SparkListener from a trait to an abstract class
## What changes were proposed in this pull request?
Scala traits are difficult to maintain binary compatibility on, and as a
re
25 matches
Mail list logo
