Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12184
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/12184#issuecomment-208244759
Thanks! Merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/12184#issuecomment-208243291
LGTM
@marmbrus Returning `Seq` seems to be not so Java-friendly?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12184#issuecomment-207725605
Looks pretty good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12184#issuecomment-207622108
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12184#issuecomment-207622107
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12184#issuecomment-207621899
**[Test build #55388 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55388/consoleFull)**
for PR 12184 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12184#issuecomment-207591845
**[Test build #55388 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55388/consoleFull)**
for PR 12184 at commit
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12184#discussion_r59015588
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1510,6 +1511,30 @@ class Dataset[T] private[sql](
}
/**
+
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12184#issuecomment-207148089
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12184#issuecomment-207148090
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12184#issuecomment-207147837
**[Test build #55262 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55262/consoleFull)**
for PR 12184 at commit
Github user rekhajoshm commented on the pull request:
https://github.com/apache/spark/pull/12184#issuecomment-207131155
thanks @srowen .updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12184#issuecomment-207127626
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rekhajoshm commented on a diff in the pull request:
https://github.com/apache/spark/pull/12184#discussion_r58959234
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1492,6 +1491,8 @@ class Dataset[T] private[sql](
* @param weights
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12184#issuecomment-207131312
**[Test build #55262 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55262/consoleFull)**
for PR 12184 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12184#issuecomment-207127616
**[Test build #55260 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55260/consoleFull)**
for PR 12184 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12184#issuecomment-207127628
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12184#issuecomment-207127089
**[Test build #55260 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55260/consoleFull)**
for PR 12184 at commit
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12184#discussion_r58833476
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1492,6 +1491,8 @@ class Dataset[T] private[sql](
* @param weights weights
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12184#discussion_r58833301
--- Diff:
sql/core/src/test/java/test/org/apache/spark/sql/JavaDatasetSuite.java ---
@@ -454,6 +481,17 @@ public void testJavaEncoder() {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12184#discussion_r58833267
--- Diff:
sql/core/src/test/java/test/org/apache/spark/sql/JavaDatasetSuite.java ---
@@ -17,33 +17,60 @@
package test.org.apache.spark.sql;
Github user rekhajoshm commented on the pull request:
https://github.com/apache/spark/pull/12184#issuecomment-206624502
@marmbrus thanks for your review. added test.thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12184#issuecomment-206624182
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12184#issuecomment-206624184
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12184#issuecomment-206037177
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12184#issuecomment-206037180
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12184#issuecomment-206036164
**[Test build #55029 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55029/consoleFull)**
for PR 12184 at commit
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/12184#issuecomment-206027097
/cc @liancheng
Should we just make the scala version return a `Seq` if `Array` doesn't
work for java?
---
If your project is set up for it, you can reply
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/12184#issuecomment-206026945
There is no test suite, please add one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12184#issuecomment-206007445
**[Test build #55029 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55029/consoleFull)**
for PR 12184 at commit
GitHub user rekhajoshm opened a pull request:
https://github.com/apache/spark/pull/12184
[SPARK-14372] [SQL] : Dataset.randomSplit() needs a Java version
## What changes were proposed in this pull request?
1.Added method randomSplitAsList() in Dataset for java
##
32 matches
Mail list logo
