[GitHub] spark pull request: [SPARK-14383] [SQL] missing "|" in the g4 file

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12156 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14383] [SQL] missing "|" in the g4 file

Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12156#issuecomment-206498803 Merged into master. Good catch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-14383] [SQL] missing "|" in the g4 file

Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/12156#issuecomment-206223273 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-14383] [SQL] missing "|" in the g4 file

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12156#issuecomment-206004514 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14383] [SQL] missing "|" in the g4 file

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12156#issuecomment-206004520 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14383] [SQL] missing "|" in the g4 file

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12156#issuecomment-206004093 **[Test build #55015 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55015/consoleFull)** for PR 12156 at commit

[GitHub] spark pull request: [SPARK-14383] [SQL] missing "|" in the g4 file

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12156#issuecomment-205975799 **[Test build #55015 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55015/consoleFull)** for PR 12156 at commit

[GitHub] spark pull request: [SPARK-14383] [SQL] missing "|" in the g4 file

Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/12156#issuecomment-205672374 @bomeng `DISTRIBUTE` `UNSET` have been defined as one rule, so we cannot use them as identifiers. This will fail for instance: `select unset from x` whereas `select

[GitHub] spark pull request: [SPARK-14383] [SQL] missing "|" in the g4 file

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12156#issuecomment-205538854 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14383] [SQL] missing "|" in the g4 file

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12156#issuecomment-205538852 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14383] [SQL] missing "|" in the g4 file

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12156#issuecomment-205538501 **[Test build #54895 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54895/consoleFull)** for PR 12156 at commit

[GitHub] spark pull request: [SPARK-14383] [SQL] missing "|" in the g4 file

Github user bomeng commented on the pull request: https://github.com/apache/spark/pull/12156#issuecomment-205516677 @hvanhovell Could you please tell me how to test? You mean manual test or else? Besides this, I have some questions to ask but not related to this JIRA. I do found

[GitHub] spark pull request: [SPARK-14383] [SQL] missing "|" in the g4 file

Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/12156#issuecomment-205509248 @bomeng good catch. You can test this easily by using these as identifiers. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-14383] [SQL] missing "|" in the g4 file

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12156#issuecomment-205508054 **[Test build #54895 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54895/consoleFull)** for PR 12156 at commit

[GitHub] spark pull request: [SPARK-14383] [SQL] missing "|" in the g4 file

Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/12156#issuecomment-205508035 Might be good to add to the existing unit tests since it was possibly a regression from the previous grammar? --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-14383] [SQL] missing "|" in the g4 file

GitHub user bomeng opened a pull request: https://github.com/apache/spark/pull/12156 [SPARK-14383] [SQL] missing "|" in the g4 file ## What changes were proposed in this pull request? A very trivial one. It missed "|" between DISTRIBUTE and SET. ## How was