[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-11 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12161#discussion_r59325685 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/ColumnarAggMapCodeGenerator.scala --- @@ -0,0 +1,193 @@ +/* + * Licensed to

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-08 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/12161#discussion_r59094076 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/ColumnarAggMapCodeGenerator.scala --- @@ -0,0 +1,193 @@ +/* + * Licensed to

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12161 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207579368 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207579373 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207578866 **[Test build #55380 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55380/consoleFull)** for PR 12161 at commit [`ec74328`](https://g

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207550406 **[Test build #55380 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55380/consoleFull)** for PR 12161 at commit [`ec74328`](https://gi

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-08 Thread sameeragarwal
Github user sameeragarwal commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207550141 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207537477 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207537480 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207536028 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-08 Thread sameeragarwal
Github user sameeragarwal commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207536205 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207536033 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-08 Thread sameeragarwal
Github user sameeragarwal commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207534882 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207511433 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207511426 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207511168 **[Test build #55354 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55354/consoleFull)** for PR 12161 at commit [`ec74328`](https://g

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207498660 **[Test build #55354 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55354/consoleFull)** for PR 12161 at commit [`ec74328`](https://gi

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-08 Thread sameeragarwal
Github user sameeragarwal commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207497421 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207495479 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207495473 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-08 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/12161#discussion_r59043603 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregateHashMap.scala --- @@ -0,0 +1,132 @@ +/* + * Licensed to t

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207321981 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207321991 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207321884 **[Test build #55336 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55336/consoleFull)** for PR 12161 at commit [`eb8a020`](https://g

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207276393 **[Test build #55336 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55336/consoleFull)** for PR 12161 at commit [`eb8a020`](https://gi

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-08 Thread sameeragarwal
Github user sameeragarwal commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207274783 Seems like amp-jenkins-worker-06 is in a bad state. test this please --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207267713 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207267717 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207267628 **[Test build #55327 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55327/consoleFull)** for PR 12161 at commit [`eb8a020`](https://g

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207236603 **[Test build #55327 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55327/consoleFull)** for PR 12161 at commit [`eb8a020`](https://gi

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-07 Thread sameeragarwal
Github user sameeragarwal commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207235417 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207234721 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207234697 **[Test build #55318 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55318/consoleFull)** for PR 12161 at commit [`eb8a020`](https://g

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207234720 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207218514 **[Test build #55318 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55318/consoleFull)** for PR 12161 at commit [`eb8a020`](https://gi

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-07 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/12161#discussion_r58981138 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregateHashMap.scala --- @@ -0,0 +1,125 @@ +/* + * Licens

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-07 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12161#discussion_r58978809 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregateHashMap.scala --- @@ -0,0 +1,132 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-07 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12161#discussion_r58978741 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregateHashMap.scala --- @@ -0,0 +1,125 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-07 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12161#discussion_r58978723 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregateHashMap.scala --- @@ -0,0 +1,125 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-07 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12161#discussion_r58978685 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregateHashMap.scala --- @@ -0,0 +1,125 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-07 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12161#discussion_r58978611 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregateHashMap.scala --- @@ -0,0 +1,125 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-07 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12161#discussion_r58978578 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregateHashMap.scala --- @@ -0,0 +1,125 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-07 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12161#discussion_r58978492 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregateHashMap.scala --- @@ -0,0 +1,125 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-07 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12161#discussion_r58978122 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregateHashMap.scala --- @@ -0,0 +1,132 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207160035 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207160037 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207159772 **[Test build #55272 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55272/consoleFull)** for PR 12161 at commit [`071a900`](https://g

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-07 Thread nongli
Github user nongli commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207146943 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207136918 **[Test build #55272 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55272/consoleFull)** for PR 12161 at commit [`071a900`](https://gi

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-07 Thread sameeragarwal
Github user sameeragarwal commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207136541 sure, added it back --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-07 Thread nongli
Github user nongli commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207134229 I think the old version makes more sense. The generated code only works for a particular schema so no reason to pass it in. --- If your project is set up for it, you ca

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-07 Thread sameeragarwal
Github user sameeragarwal commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-207049242 sorry -- I hadn't update the correct generated code in the PR description. Please let me know if this is OK or you still prefer the old version. --- If your proj

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-07 Thread nongli
Github user nongli commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206949611 The generated code takes a schema in the ctor and creates one as a member var. Let's just use the member var one like you had originally. --- If your project is set up

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206706739 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206706738 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206706611 **[Test build #55180 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55180/consoleFull)** for PR 12161 at commit [`ff6ebbe`](https://g

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206706059 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206706060 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206705916 **[Test build #55179 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55179/consoleFull)** for PR 12161 at commit [`cae66fd`](https://g

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206691544 **[Test build #55180 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55180/consoleFull)** for PR 12161 at commit [`ff6ebbe`](https://gi

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206691029 **[Test build #55179 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55179/consoleFull)** for PR 12161 at commit [`cae66fd`](https://gi

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-06 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/12161#discussion_r58788879 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregateHashMap.scala --- @@ -0,0 +1,132 @@ +/* + * Licensed to t

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-06 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/12161#discussion_r58788712 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregateHashMap.scala --- @@ -0,0 +1,132 @@ +/* + * Licensed to t

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206275246 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206275251 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206274280 **[Test build #55104 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55104/consoleFull)** for PR 12161 at commit [`13b6b44`](https://g

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206220304 **[Test build #55104 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55104/consoleFull)** for PR 12161 at commit [`13b6b44`](https://gi

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206190576 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206190571 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-06 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206190355 **[Test build #55094 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55094/consoleFull)** for PR 12161 at commit [`e30d40d`](https://g

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206142648 **[Test build #55094 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55094/consoleFull)** for PR 12161 at commit [`e30d40d`](https://gi

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206080177 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206080184 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206079654 **[Test build #55068 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55068/consoleFull)** for PR 12161 at commit [`bd96657`](https://g

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206062012 **[Test build #55068 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55068/consoleFull)** for PR 12161 at commit [`bd96657`](https://gi

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206040363 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206040360 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206040332 **[Test build #55042 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55042/consoleFull)** for PR 12161 at commit [`a31be48`](https://g

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-05 Thread sameeragarwal
Github user sameeragarwal commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206037766 cc @nongli --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206032405 **[Test build #55042 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55042/consoleFull)** for PR 12161 at commit [`a31be48`](https://gi

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-05 Thread sameeragarwal
Github user sameeragarwal commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206030967 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206026226 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206026230 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206026222 **[Test build #55036 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55036/consoleFull)** for PR 12161 at commit [`a31be48`](https://g

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206025288 **[Test build #55036 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55036/consoleFull)** for PR 12161 at commit [`a31be48`](https://gi

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-05 Thread sameeragarwal
Github user sameeragarwal commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206024935 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206023097 **[Test build #55034 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55034/consoleFull)** for PR 12161 at commit [`a31be48`](https://gi

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206024191 **[Test build #55034 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55034/consoleFull)** for PR 12161 at commit [`a31be48`](https://g

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206024198 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206024196 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-05 Thread sameeragarwal
Github user sameeragarwal commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206021282 ```java /* 001 */ public Object generate(Object[] references) { /* 002 */ return new GeneratedIterator(references); /* 003 */ } /* 004 */ /*