[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-06 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-206140527 I see the problem. ``` [error]

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-06 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-206140754 Will fix it using a PR with [HOT]. Sorry for it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-06 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-206139977 https://amplab.cs.berkeley.edu/jenkins/job/spark-master-compile-maven-scala-2.10/ ? --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-06 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-206138869 Or I need to do it in my local environment? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-06 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-206138089 Sure. Could you show me how to find the build log? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-06 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-206137008 @gatorsmile Seems scala 2.10 build is broken. Can you take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12169 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-206126467 Merged into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-206100034 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-206100033 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-206099910 **[Test build #55072 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55072/consoleFull)** for PR 12169 at commit

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-206071828 **[Test build #55072 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55072/consoleFull)** for PR 12169 at commit

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-206061371 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-206061368 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-206060792 **[Test build #55049 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55049/consoleFull)** for PR 12169 at commit

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-206037747 **[Test build #55049 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55049/consoleFull)** for PR 12169 at commit

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/12169#discussion_r58632645 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala --- @@ -215,11 +215,20 @@ class HiveSqlAstBuilder extends

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-206037824 LGTM we just need to make tests pass now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-206037592 Build is broken I think. retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-206017548 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-206017535 **[Test build #55031 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55031/consoleFull)** for PR 12169 at commit

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-206017552 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-206015294 **[Test build #55031 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55031/consoleFull)** for PR 12169 at commit

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-206013206 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-206001541 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-206001545 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/12169#discussion_r58616584 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -553,9 +553,13 @@ class SparkSqlAstBuilder extends

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-205959612 Looks pretty good, just a minor comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/12169#discussion_r58600702 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -553,9 +553,13 @@ class SparkSqlAstBuilder extends

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-205892839 Thanks for the review! @hvanhovell Also cc @yhuai @andrewor14 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-205855786 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-205855791 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-205855383 **[Test build #54983 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54983/consoleFull)** for PR 12169 at commit

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-205808491 **[Test build #54983 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54983/consoleFull)** for PR 12169 at commit

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-205699757 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-205699750 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-205698876 **[Test build #54959 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54959/consoleFull)** for PR 12169 at commit

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/12169#discussion_r58495982 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -75,17 +75,17 @@ statement | ALTER TABLE

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/12169#discussion_r58493735 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -75,17 +75,17 @@ statement | ALTER TABLE

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-205664381 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-205664309 **[Test build #54958 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54958/consoleFull)** for PR 12169 at commit

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-205664375 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-205662059 **[Test build #54959 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54959/consoleFull)** for PR 12169 at commit

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-205658050 **[Test build #54958 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54958/consoleFull)** for PR 12169 at commit

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-04 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/12169 [SPARK-14396] [SQL] Throw Exceptions for DDLs of Partitioned Views What changes were proposed in this pull request? Because the concept of partitioning is associated with physical