[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-26 Thread JoshRosen
Github user JoshRosen closed the pull request at: https://github.com/apache/spark/pull/12171 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-08 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-207551094 Now that we no longer publish assembly JARs for Spark, I don't think that shading is going to require exclusions because the only reason to do that would be if we wan

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-07 Thread ash211
Github user ash211 commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-207240207 @JoshRosen Guava and Jetty excludes might have been done when they were shaded: https://issues.apache.org/jira/browse/SPARK-2848 - shade Guava https://issues.apac

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-206099245 Hmm, the FlumePollingStreamSuite test looks broken because it has hung twice now. I'll try to reproduce offline. --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-206005487 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-206005390 **[Test build #55002 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55002/consoleFull)** for PR 12171 at commit [`0bb11be`](https://g

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-206005481 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-205999807 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/12171#discussion_r58610193 --- Diff: pom.xml --- @@ -840,14 +827,13 @@ org.apache.avro avro-mapred ${avro.version} +

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-205962888 LGTM if sbt and maven tests pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/12171#discussion_r58602465 --- Diff: tools/pom.xml --- @@ -71,6 +71,16 @@ org.apache.maven.plugins maven-source-plugin + --- End diff

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/12171#discussion_r58601918 --- Diff: pom.xml --- @@ -840,14 +827,13 @@ org.apache.avro avro-mapred ${avro.version} +

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-205922367 **[Test build #55002 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55002/consoleFull)** for PR 12171 at commit [`0bb11be`](https://gi

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-205921075 I re-added joda-time; let's see if that fixes Hive. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-205858120 It looks like Hive might actually need Joda time: ``` - analyze MetastoreRelations *** FAILED *** org.apache.spark.sql.execution.QueryExecutionExcept

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-205780099 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-205780102 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-205780064 **[Test build #54972 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54972/consoleFull)** for PR 12171 at commit [`36430de`](https://g

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread steveloughran
Github user steveloughran commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-205744467 without looking at the details, I appreciated the ambition —and like that wildcard artifact exclusion. what is the dependency graph that SBT generates f

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-205719339 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-205719362 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-205719312 **[Test build #54967 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54967/consoleFull)** for PR 12171 at commit [`51853c7`](https://g

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-205717007 **[Test build #54972 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54972/consoleFull)** for PR 12171 at commit [`36430de`](https://gi

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-205714343 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-205714331 **[Test build #54971 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54971/consoleFull)** for PR 12171 at commit [`fc938a0`](https://g

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-205714338 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-205712989 _Actually_, we might be able to use `sbt-pom-reader` 2.10-RC2, since we only require Maven 3.2.1+ and that artifact uses 3.2.2: https://github.com/sbt/sbt-pom-reader/

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-205712554 **[Test build #54971 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54971/consoleFull)** for PR 12171 at commit [`fc938a0`](https://gi

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-205712227 In fact, being able to use the nice wildcard syntax may be a way's off because the official sbt-pom-reader doesn't support Maven 3.3.x due to API incompatibilities:

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-205709605 ``` org.apache.maven.model.building.ModelBuildingException: 10 problems were encountered while building the effective model for org.apache.spark:spark-hive_2.11:2

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-205695469 ``` [warn] module not found: org.pentaho#pentaho-aggdesigner-algorithm;5.1.5-jhyde [warn] public: tried [warn] https://repo1.maven.org/maven2/

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-205687993 **[Test build #54963 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54963/consoleFull)** for PR 12171 at commit [`51853c7`](https://g

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-205688006 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-205687999 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-205686151 **[Test build #54963 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54963/consoleFull)** for PR 12171 at commit [`51853c7`](https://gi

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-05 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-205685535 A few quick questions: - [ ] Can we remove all of the Guava excludes now? They're all over the place but it's not clear whether it's necessary anymore. If we

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-04 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/12171#issuecomment-205684795 Oh, /cc @vanzin as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14399] Remove unnecessary excludes from...

2016-04-04 Thread JoshRosen
GitHub user JoshRosen opened a pull request: https://github.com/apache/spark/pull/12171 [SPARK-14399] Remove unnecessary excludes from POMs and simplify Hive POM This patch aims to simplify our build by removing a number of unnecessary excludes from the build. The individual commit