Github user rekhajoshm closed the pull request at:
https://github.com/apache/spark/pull/12183
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user rekhajoshm commented on the pull request:
https://github.com/apache/spark/pull/12183#issuecomment-206171895
ok thanks @andrewor14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12183#issuecomment-206136314
@rekhajoshm I've opened #12198 to illustrate what I mean. I don't think the
changes in this patch are correct so I would recommend that we close this PR.
---
If
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12183#issuecomment-206033483
@rekhajoshm I think there is some misunderstanding on what the issue is.
The JIRA is saying all the create/drop methods in `SessionCatalog` should take
in a flag
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12183#discussion_r58631403
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -474,15 +479,8 @@ class SessionCatalog(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12183#discussion_r58631042
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -84,15 +84,21 @@ class SessionCatalog(
//
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12183#discussion_r58627907
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -84,15 +84,21 @@ class SessionCatalog(
//
Github user rekhajoshm commented on the pull request:
https://github.com/apache/spark/pull/12183#issuecomment-206017437
@yhuai - will do, one question is., as database calls had
ignoreIfExists/ignoreIfNotExists flag, now with adding existence check this
boolean loses meaning.Do we
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/12183#issuecomment-206004627
@rekhajoshm Thank you for working on this! I think there are other methods
in SessionCatalog that handle an existing table/db/function that do not check
the existence of
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12183#issuecomment-205999728
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
GitHub user rekhajoshm opened a pull request:
https://github.com/apache/spark/pull/12183
[SPARK-14410] [SQL] : SessionCatalog needs to check database/table/function
existence
## What changes were proposed in this pull request?
1.Check for existence of Function in catalog,
11 matches
Mail list logo
