Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-210274197
Let me close this due to an earlier duplicate one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user viirya closed the pull request at:
https://github.com/apache/spark/pull/12207
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-209274563
ping @jkbradley @mengxr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-208686519
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-208686517
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-208686365
**[Test build #55568 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55568/consoleFull)**
for PR 12207 at commit
[`4309001`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-208660505
**[Test build #55568 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55568/consoleFull)**
for PR 12207 at commit
[`4309001`](https://gi
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/12207#discussion_r59310493
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1181,18 +1181,25 @@ def approxQuantile(self, col, probabilities,
relativeError):
Space-efficien
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/12207#discussion_r59281355
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1181,18 +1181,25 @@ def approxQuantile(self, col, probabilities,
relativeError):
Space-efficie
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-208254752
LGTM, pending the discussion on the `@see` link. @jkbradley?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12207#discussion_r59176931
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala ---
@@ -71,6 +71,28 @@ final class DataFrameStatFunctions private[sql](df:
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-208228565
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-208228572
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-208227928
**[Test build #55512 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55512/consoleFull)**
for PR 12207 at commit
[`89d4d3e`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-208191917
**[Test build #55512 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55512/consoleFull)**
for PR 12207 at commit
[`89d4d3e`](https://gi
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/12207#discussion_r59161347
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1181,18 +1181,26 @@ def approxQuantile(self, col, probabilities,
relativeError):
Space-efficien
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12207#discussion_r59160367
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1181,18 +1181,26 @@ def approxQuantile(self, col, probabilities,
relativeError):
Space-efficien
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-208142363
ping @jkbradley @MLnick
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-207649125
@jkbradley Can you take a look too? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/12207#discussion_r59103347
--- Diff: python/pyspark/sql/tests.py ---
@@ -702,6 +702,14 @@ def test_approxQuantile(self):
self.assertEqual(len(aq), 3)
self.asser
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-207493449
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-207493446
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-207493128
**[Test build #55350 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55350/consoleFull)**
for PR 12207 at commit
[`b64bd4e`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-207491005
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-207491009
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-207490654
**[Test build #55349 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55349/consoleFull)**
for PR 12207 at commit
[`619660d`](https://g
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/12207#discussion_r59041277
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala ---
@@ -71,6 +71,28 @@ final class DataFrameStatFunctions private[sql](df:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-207455932
**[Test build #55350 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55350/consoleFull)**
for PR 12207 at commit
[`b64bd4e`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-207454228
**[Test build #55349 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55349/consoleFull)**
for PR 12207 at commit
[`619660d`](https://gi
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/12207#discussion_r59028212
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1181,7 +1181,7 @@ def approxQuantile(self, col, probabilities,
relativeError):
Space-efficient
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12207#discussion_r59027626
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1181,7 +1181,7 @@ def approxQuantile(self, col, probabilities,
relativeError):
Space-efficient
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/12207#discussion_r59027297
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1181,7 +1181,7 @@ def approxQuantile(self, col, probabilities,
relativeError):
Space-efficient
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12207#discussion_r59026778
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1181,7 +1181,7 @@ def approxQuantile(self, col, probabilities,
relativeError):
Space-efficient
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12207#discussion_r59026553
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1181,7 +1181,7 @@ def approxQuantile(self, col, probabilities,
relativeError):
Space-efficient
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12207#discussion_r59026264
--- Diff: python/pyspark/sql/tests.py ---
@@ -702,6 +702,14 @@ def test_approxQuantile(self):
self.assertEqual(len(aq), 3)
self.asser
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12207#discussion_r59026055
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala ---
@@ -71,6 +71,28 @@ final class DataFrameStatFunctions private[sql](df:
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-207425534
ping @jkbradley @MLnick any further comments for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-206834653
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-206834644
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-206834081
**[Test build #55216 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55216/consoleFull)**
for PR 12207 at commit
[`75edcb1`](https://g
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/12207#discussion_r58851404
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala ---
@@ -71,6 +71,28 @@ final class DataFrameStatFunctions private[sql](df:
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-206804215
@MLnick Thanks for review. I've updated PySpark API.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-206744068
Thanks @viirya - any chance to update the PySpark API at the same time? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12207#discussion_r58831208
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameStatSuite.scala ---
@@ -150,6 +150,19 @@ class DataFrameStatSuite extends QueryTest with
Shar
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12207#discussion_r58830576
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala ---
@@ -71,6 +71,28 @@ final class DataFrameStatFunctions private[sql](df:
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-206665554
cc @jkbradley
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-206443948
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-206443951
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-206443637
**[Test build #55117 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55117/consoleFull)**
for PR 12207 at commit
[`47d52b9`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-206411305
**[Test build #55117 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55117/consoleFull)**
for PR 12207 at commit
[`47d52b9`](https://gi
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-206408886
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-206407403
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-206407301
**[Test build #55116 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55116/consoleFull)**
for PR 12207 at commit
[`47d52b9`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-206407411
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12207#issuecomment-206402791
**[Test build #55116 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55116/consoleFull)**
for PR 12207 at commit
[`47d52b9`](https://gi
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/12207
[SPARK-14432][SQL] Add API to calculate the approximate quantiles for
multiple columns
## What changes were proposed in this pull request?
JIRA: https://issues.apache.org/jira/browse/SPARK-14432
56 matches
Mail list logo
