[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-28 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r61534345 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/UDTRegistration.scala --- @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-28 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r61474690 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/UDTRegistration.scala --- @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-28 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r61473084 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/UDTRegistration.scala --- @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software F

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r61401723 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/UDTRegistration.scala --- @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Softwar

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-28 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-215346566 @mengxr @dbtsai Thanks for reviewing this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12259 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-28 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-215345283 Merged into master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-215324565 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-215324562 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-215324403 **[Test build #57219 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57219/consoleFull)** for PR 12259 at commit [`1c230ae`](https://g

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-215320081 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-215320083 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-215319930 **[Test build #57217 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57217/consoleFull)** for PR 12259 at commit [`9ed0f30`](https://g

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-215311747 **[Test build #57219 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57219/consoleFull)** for PR 12259 at commit [`1c230ae`](https://gi

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-27 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-215310697 LGTM pending Jenkins --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-27 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r61373781 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala --- @@ -117,6 +117,7 @@ class SQLContext private[sql]( * * @since 1.6.0

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-27 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r61373671 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/util/MLlibTestSparkContext.scala --- @@ -24,14 +24,18 @@ import org.scalatest.Suite import or

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-215310117 **[Test build #57217 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57217/consoleFull)** for PR 12259 at commit [`9ed0f30`](https://gi

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-215307961 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-215307962 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-215307877 **[Test build #57207 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57207/consoleFull)** for PR 12259 at commit [`45e87d9`](https://g

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-215298452 **[Test build #57207 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57207/consoleFull)** for PR 12259 at commit [`45e87d9`](https://gi

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-27 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-215298262 @mengxr Thanks for these comments. I simplified `UDTRegistration`, `VectorUDTSuite` and `MatrixUDTSuite`. Please take a look and let me know if you have further feedback

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-27 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-215259040 Made another pass. Please also address my previous comment on `UDTRegistration`. It doesn't seem necessary to overload methods with different types (Are they all covered

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-27 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r61351414 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/util/MLlibTestSparkContext.scala --- @@ -24,14 +24,18 @@ import org.scalatest.Suite import or

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-27 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r61351335 --- Diff: mllib/src/test/scala/org/apache/spark/ml/linalg/VectorUDTSuite.scala --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-27 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r61351318 --- Diff: mllib/src/test/scala/org/apache/spark/ml/linalg/MatrixUDTSuite.scala --- @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-27 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r61351184 --- Diff: mllib/src/test/scala/org/apache/spark/ml/linalg/MatrixUDTSuite.scala --- @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-27 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r61227920 --- Diff: mllib/src/test/scala/org/apache/spark/ml/linalg/MatrixUDTSuite.scala --- @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-27 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r61212745 --- Diff: mllib/src/test/scala/org/apache/spark/ml/linalg/MatrixUDTSuite.scala --- @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-26 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r61183805 --- Diff: mllib/src/test/scala/org/apache/spark/ml/linalg/MatrixUDTSuite.scala --- @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-26 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-214916566 ping @dbtsai @mengxr Can you take a look? Any more comments or is this ready to merge now? Thanks. --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-214582968 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-214582969 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-214582825 **[Test build #56946 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56946/consoleFull)** for PR 12259 at commit [`de7ea5d`](https://g

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-25 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-214570155 Created a JIRA https://issues.apache.org/jira/browse/SPARK-14906 to follow this. --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-214569974 **[Test build #56946 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56946/consoleFull)** for PR 12259 at commit [`de7ea5d`](https://gi

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-25 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-214569287 @dbtsai yea. Forget to do that. Updating now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-25 Thread dbtsai
Github user dbtsai commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-214562802 I think `override def pyUDT: String = "pyspark.mllib.linalg.MatrixUDT"` has to be changed; otherwise, this will cause inconsistent result. Maybe this can be removed from

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-23 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-213897223 @mengxr @dbtsai Your comments are addressed now. Please take a look again when you have a change. Thanks. --- If your project is set up for it, you can reply to this em

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-213892427 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-213892428 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-213892392 **[Test build #56831 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56831/consoleFull)** for PR 12259 at commit [`06bdbc5`](https://g

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-213881371 **[Test build #56831 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56831/consoleFull)** for PR 12259 at commit [`06bdbc5`](https://gi

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-23 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-213881020 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-213880954 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-213880953 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-213880936 **[Test build #56828 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56828/consoleFull)** for PR 12259 at commit [`06bdbc5`](https://g

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-213873676 **[Test build #56828 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56828/consoleFull)** for PR 12259 at commit [`06bdbc5`](https://gi

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-213872213 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-213872211 **[Test build #56826 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56826/consoleFull)** for PR 12259 at commit [`3917f6b`](https://g

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-213872215 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-213872166 **[Test build #56826 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56826/consoleFull)** for PR 12259 at commit [`3917f6b`](https://gi

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-213870537 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-213870536 **[Test build #56823 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56823/consoleFull)** for PR 12259 at commit [`023d281`](https://g

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-213870539 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-213870512 **[Test build #56823 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56823/consoleFull)** for PR 12259 at commit [`023d281`](https://gi

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r60837881 --- Diff: mllib/src/test/scala/org/apache/spark/ml/linalg/MatrixUDTSuite.scala --- @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r60836845 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala --- @@ -117,6 +118,12 @@ class SQLContext private[sql]( * * @since 1.6.

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-22 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r60818079 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala --- @@ -117,6 +118,12 @@ class SQLContext private[sql]( * * @since 1.6.

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-22 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r60811552 --- Diff: mllib/src/test/scala/org/apache/spark/ml/linalg/VectorUDTSuite.scala --- @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-22 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-213551922 I made another pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-22 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r60785238 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/UDTRegistrationSuite.scala --- @@ -0,0 +1,304 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-22 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r60784408 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala --- @@ -117,6 +118,12 @@ class SQLContext private[sql]( * * @since 1.6.

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-22 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r60784229 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/udt/BuiltInUDT.scala --- @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-22 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r60784001 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/UDTRegistration.scala --- @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software F

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-22 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r60783965 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/UDTRegistration.scala --- @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software F

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-22 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r60783906 --- Diff: mllib/src/test/scala/org/apache/spark/ml/linalg/VectorUDTSuite.scala --- @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-22 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r60783908 --- Diff: mllib/src/test/scala/org/apache/spark/ml/linalg/VectorUDTSuite.scala --- @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-22 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r60783900 --- Diff: mllib/src/test/scala/org/apache/spark/ml/linalg/VectorUDTSuite.scala --- @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-22 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r60783891 --- Diff: mllib/src/test/scala/org/apache/spark/ml/linalg/VectorUDTSuite.scala --- @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-22 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r60783863 --- Diff: mllib/src/main/scala/org/apache/spark/ml/linalg/MatrixUDT.scala --- @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-22 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r60783883 --- Diff: mllib/src/main/scala/org/apache/spark/ml/linalg/VectorUDT.scala --- @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-22 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r60783855 --- Diff: mllib/src/main/scala/org/apache/spark/ml/linalg/MatrixUDT.scala --- @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-22 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r60776248 --- Diff: mllib/src/test/scala/org/apache/spark/ml/linalg/MatrixUDTSuite.scala --- @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-22 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r60776001 --- Diff: mllib/src/test/scala/org/apache/spark/ml/linalg/MatrixUDTSuite.scala --- @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-22 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r60775630 --- Diff: mllib/src/main/scala/org/apache/spark/ml/linalg/VectorUDT.scala --- @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-22 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r60775523 --- Diff: mllib/src/main/scala/org/apache/spark/ml/linalg/MatrixUDT.scala --- @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-22 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r60775018 --- Diff: mllib/src/main/scala/org/apache/spark/ml/linalg/MatrixUDT.scala --- @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-22 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r60757277 --- Diff: mllib/src/main/scala/org/apache/spark/ml/linalg/MatrixUDT.scala --- @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-22 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-213353410 ping @dbtsai @mengxr @marmbrus Is this ready? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-213350625 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-213350624 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-213350285 **[Test build #56681 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56681/consoleFull)** for PR 12259 at commit [`434b1b4`](https://g

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-213310851 **[Test build #56681 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56681/consoleFull)** for PR 12259 at commit [`434b1b4`](https://gi

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-212732400 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-212732403 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-212732276 **[Test build #56461 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56461/consoleFull)** for PR 12259 at commit [`5caa0aa`](https://g

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-212706327 **[Test build #56461 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56461/consoleFull)** for PR 12259 at commit [`5caa0aa`](https://gi

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-20 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r60519534 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala --- @@ -112,6 +113,11 @@ class SQLContext private[sql]( */ def newSessio

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-212692215 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-212692211 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-212692103 **[Test build #56444 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56444/consoleFull)** for PR 12259 at commit [`42ff175`](https://g

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-212657801 **[Test build #56444 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56444/consoleFull)** for PR 12259 at commit [`42ff175`](https://gi

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-20 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r60505530 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala --- @@ -112,6 +113,11 @@ class SQLContext private[sql]( */ def newSessio

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-20 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/12259#discussion_r60477354 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala --- @@ -112,6 +113,11 @@ class SQLContext private[sql]( */ def newSess

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-212371617 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-212371621 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-212371131 **[Test build #56346 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56346/consoleFull)** for PR 12259 at commit [`5aaf9db`](https://g

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-212338863 **[Test build #56346 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56346/consoleFull)** for PR 12259 at commit [`5aaf9db`](https://gi

  1   2   3   >