Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/12707#issuecomment-215809500
I created https://issues.apache.org/jira/browse/SPARK-15006 and
https://github.com/typesafehub/genjavadoc/issues/83 to track the issue with
package private objects.
--
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12707
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12707#issuecomment-215665077
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/12707#issuecomment-215628995
+1 on merging this first and fixing remaining issues later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/12707#issuecomment-215530295
@srowen, I did quite some digging through the genjavadoc codebase when
re-implementing @mengxr's initial fix. I can try to fix the group warnings and
object privacy is
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12707#issuecomment-215357914
Yeah, the problem is that Java 8 has a much stricter javadoc tool. `@group`
isn't a valid javadoc tag, so when `ALSModel.scala` gets translated to Java to
javadoc it, it
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/12707#issuecomment-215260627
Though the doc compiles, it doesn't seem that the package private objects
are hided. @jodersky Could you double check?
---
If your project is set up for it, you can rep
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/12707#issuecomment-215259445
Yeah, I think that was it. Forgot that I had pinned Java 7 for docs on
Jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/12707#issuecomment-215259124
@JoshRosen Are you using Java 8? I tested this on Java 7 with the latest
master. It worked fine.
---
If your project is set up for it, you can reply to this email and h
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/12707#issuecomment-215258121
Hmm, the current genjavadoc also produces errors so I didn't really look
into it. How does the final output compare? Could this be due to java 8's
stricter behaviour a
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/12707#issuecomment-215257559
Actually, it looks like this might be broken even prior to this patch :(
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/12707#issuecomment-215255118
I saw some errors running this locally though `jekyll`:
```
[error]
/Users/joshrosen/Documents/spark/mllib/target/java/org/apache/spark/ml/recommendation/
Github user jodersky commented on the pull request:
https://github.com/apache/spark/pull/12707#issuecomment-215010184
The work I submitted upstream doesn't specifically target that issue,
however it is actually plausible that it fixes the private interface issue
as a side effect
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12707#issuecomment-215006856
Seems reasonable to me if the upstream version does all that's needed.
I wonder if this new version happens to fix the problem in ...
https://issues.apache.org/jira/b
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12707#issuecomment-214884014
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12707#issuecomment-214884017
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12707#issuecomment-214883726
**[Test build #57016 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57016/consoleFull)**
for PR 12707 at commit
[`f7d649c`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12707#issuecomment-214851113
**[Test build #57016 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57016/consoleFull)**
for PR 12707 at commit
[`f7d649c`](https://gi
18 matches
Mail list logo
