Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/2420#issuecomment-55957287
OK, will do!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2420#issuecomment-55957213
Can you just make a follow up PR with the change? I don' think we have
permission to reopen things and we can't roll back merges in apache only add
new commits that rev
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/2420#issuecomment-55956278
@marmbrus I just pushed a fix to `nchammas:selective-testing` for [this
issue](https://github.com/apache/spark/pull/2420#discussion_r17692117), and I
also have the dummy
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2420#discussion_r17692117
--- Diff: dev/run-tests ---
@@ -70,42 +99,69 @@ echo ""
echo
"="
echo "Runn
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/2420#issuecomment-55955736
Whoops! I was making a fix right now that found in testing locally (and
that I was going to confirm got fixed with the dummy commit.)
---
If your project is set up for
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2420
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2420#issuecomment-55948936
@pwendell @JoshRosen FYI, I'm going to merge this. I'll try and watch
jenkins to see if anything breaks.
---
If your project is set up for it, you can reply to this em
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/2420#issuecomment-55944640
> I'm not very good at reviewing bash code (who is?)
Dunno if that was a rhetorical question (I'm no expert by any means!), but
@pwendell has reviewed some of my
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/2420#issuecomment-55943343
Yea that makes sense to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/2420#issuecomment-55943175
Dummy commit to change a SQL file and also hack `dev/run-tests` to ignore
the changes to itself in the diff. That should trigger a SQL-only set of tests.
---
If your pr
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/2420#issuecomment-55942909
What's the dummy route?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/2420#issuecomment-55942682
> At some point maybe we should consider writing these in Python instead of
bash...
Amen.
So shall we go the dummy commit route first, and then revert,
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/2420#issuecomment-55942318
This looks good to me, but I'm not very good at reviewing bash code (who
is?). I guess we can merge and watch closely the next few PRs to see if they
are functioning properl
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2420#issuecomment-55941569
oh hmmm, I guess its also okay to do a dummy follow up PR to make sure
things are working.
@rxin do you have a second to look this over? I think its mostly chan
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/2420#issuecomment-55941034
Since `dev/run-tests` has also been modified, Jenkins will still run all
the tests.
If you want, I can have the dummy SQL commit also temporarily hack
`dev/run-
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2420#issuecomment-55931582
Yeah, thanks for working on this! :) What do you think about making a dummy
commit in this PR that changes SQL to make sure everything tests as expected?
You can commit
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/2420#issuecomment-55900507
cc @marmbrus @pwendell Dunno if you guys got notified via JIRA of this pull
request or not.
---
If your project is set up for it, you can reply to this email and have y
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2420#issuecomment-55838032
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20438/consoleFull)
for PR 2420 at commit
[`db3fa2d`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2420#issuecomment-55837405
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20436/consoleFull)
for PR 2420 at commit
[`f9e23f6`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2420#issuecomment-55833589
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20438/consoleFull)
for PR 2420 at commit
[`db3fa2d`](https://github.com/ap
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2420#issuecomment-55832913
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20436/consoleFull)
for PR 2420 at commit
[`f9e23f6`](https://github.com/ap
21 matches
Mail list logo
