Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12340#issuecomment-211550949
Oops. Sorry again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12340#issuecomment-211548789
Let me fix that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/12340#issuecomment-211548275
@dongjoon-hyun Seems this breaks scala 2.10 test? Can you take a look?
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12340
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12340#issuecomment-211540230
Thank you so much for your reviewing and merging, @rxin !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12340#issuecomment-211538667
Thanks - merging in master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12340#issuecomment-211538391
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12340#issuecomment-211538395
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12340#issuecomment-211538077
**[Test build #56084 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56084/consoleFull)**
for PR 12340 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12340#issuecomment-211487788
**[Test build #56084 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56084/consoleFull)**
for PR 12340 at commit
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12340#discussion_r60098395
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -487,6 +487,44 @@ case class PrintToStderr(child:
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12340#discussion_r60096468
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -487,6 +487,44 @@ case class PrintToStderr(child:
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12340#discussion_r59979748
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -487,6 +487,44 @@ case class PrintToStderr(child:
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12340#discussion_r59979739
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -487,6 +487,44 @@ case class PrintToStderr(child:
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12340#issuecomment-210877367
Hi, @rxin
Does the latest code fit your intention?
If I missed something again, please let me know.
Thank you for review so far. I learned a little
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12340#issuecomment-210785314
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12340#issuecomment-210785315
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12340#issuecomment-210785244
**[Test build #56005 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56005/consoleFull)**
for PR 12340 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12340#issuecomment-210775598
**[Test build #56005 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56005/consoleFull)**
for PR 12340 at commit
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12340#issuecomment-210775563
Now, `assert_true` uses implicit type casts. Code is much cleaner.
Also, during reviews, I fixed my critical bug: I missed adding generated
child code.
---
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12340#issuecomment-210762099
I see. I'll use `with ImplicitCastInputTypes`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12340#issuecomment-210729011
Yea I'd say we just support boolean type here for now. If people run into
issue with this we can add other things in the future. I'd much rather have a
simpler
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12340#discussion_r59961811
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -487,6 +487,43 @@ case class PrintToStderr(child:
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12340#issuecomment-210682394
Hi, @rxin .
Do you think we need to implement `assert_true` with different behavior in
Spark?
If then, please let me know. I'll change that.
---
If your
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12340#issuecomment-210610347
In Spark,
```
scala> sql("select not(0)").head
org.apache.spark.sql.AnalysisException: cannot resolve '(NOT 0)' due to
data type mismatch: argument 1
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12340#issuecomment-210609296
It's because that is the real behavior of `assert_null`. When I used
implicit type cast yesterday. It works differently with Hive assert_null. For
example,
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12340#issuecomment-210594102
Actually @dongjoon-hyun why wouldn't you just use the implicit type cast to
boolean type?
---
If your project is set up for it, you can reply to this email and have
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12340#issuecomment-210593850
Thanks - merging in master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12340#issuecomment-210592040
Thanks to you, I changed the followings so far.
* Move testcase into `HiveTypeCoercionSuite` in sql module.
* Create
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12340#issuecomment-210414562
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12340#issuecomment-210414566
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12340#issuecomment-210414400
**[Test build #55915 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55915/consoleFull)**
for PR 12340 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12340#issuecomment-210383165
**[Test build #55915 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55915/consoleFull)**
for PR 12340 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12340#issuecomment-210373814
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12340#issuecomment-210373810
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12340#issuecomment-210373329
**[Test build #55907 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55907/consoleFull)**
for PR 12340 at commit
36 matches
Mail list logo
