Github user adrian-wang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12391#discussion_r59838034
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogSuite.scala
 ---
    @@ -17,20 +17,22 @@
     
     package org.apache.spark.sql.hive
     
    +import java.io.File
    +
     import org.apache.hadoop.conf.Configuration
     import org.apache.hadoop.util.VersionInfo
     
     import org.apache.spark.SparkConf
    +import org.apache.spark.sql.catalyst.FunctionIdentifier
     import org.apache.spark.sql.catalyst.catalog._
     import org.apache.spark.sql.hive.client.{HiveClient, IsolatedClientLoader}
    -import org.apache.spark.util.Utils
     
     /**
      * Test suite for the [[HiveExternalCatalog]].
      */
     class HiveExternalCatalogSuite extends CatalogTestCases {
     
    -  private val client: HiveClient = {
    +  private lazy val client: HiveClient = {
    --- End diff --
    
    maybe `lazy` is better?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to