[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup

2016-05-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12399 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup

2016-05-02 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-216300544 Thanks, merging to master and 2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup

2016-04-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-215948426 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup

2016-04-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-215948427 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup

2016-04-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-215948384 **[Test build #57427 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57427/consoleFull)** for PR 12399 at commit

[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup

2016-04-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-215944898 **[Test build #57427 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57427/consoleFull)** for PR 12399 at commit

[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup

2016-04-30 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-215944743 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup

2016-04-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-215942539 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup

2016-04-30 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-215942514 **[Test build #57410 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57410/consoleFull)** for PR 12399 at commit

[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup

2016-04-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-215942537 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup

2016-04-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-215940178 **[Test build #57410 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57410/consoleFull)** for PR 12399 at commit

[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup

2016-04-29 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-215940097 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup

2016-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-215939852 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup

2016-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-215939851 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup

2016-04-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-215939829 **[Test build #57408 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57408/consoleFull)** for PR 12399 at commit

[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup

2016-04-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-215934261 **[Test build #57408 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57408/consoleFull)** for PR 12399 at commit

[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup

2016-04-29 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-215892595 Sorry this went stale. Do we still want to try and get this in? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup

2016-04-19 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12399#discussion_r60335271 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala --- @@ -130,60 +126,52 @@ case class Invoke( case

[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup

2016-04-19 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/12399#discussion_r60267607 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala --- @@ -130,60 +126,52 @@ case class Invoke( case

[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup

2016-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-211699140 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup

2016-04-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-211699139 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup

2016-04-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-211698745 **[Test build #56164 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56164/consoleFull)** for PR 12399 at commit

[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup

2016-04-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-211659729 **[Test build #56164 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56164/consoleFull)** for PR 12399 at commit

[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup

2016-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-210102541 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup

2016-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-210102537 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup

2016-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-210102167 **[Test build #55825 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55825/consoleFull)** for PR 12399 at commit

[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup

2016-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-210054980 **[Test build #55825 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55825/consoleFull)** for PR 12399 at commit

[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup

2016-04-14 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12399#issuecomment-210053519 cc @marmbrus @yhuai @liancheng --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-14637][SQL] object expressions cleanup

2016-04-14 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/12399 [SPARK-14637][SQL] object expressions cleanup ## What changes were proposed in this pull request? Simplify and clean up some object expressions: 1. simplify the logic to handle