Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12404#issuecomment-210662310
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12404#issuecomment-210662305
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12404#issuecomment-210662151
**[Test build #55961 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55961/consoleFull)**
for PR 12404 at commit
[`b702e72`](https://g
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/12404#issuecomment-210649760
Sounds good if people prefer to keep them separate I'll close this out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user holdenk closed the pull request at:
https://github.com/apache/spark/pull/12404
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12404#issuecomment-210649318
**[Test build #55961 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55961/consoleFull)**
for PR 12404 at commit
[`b702e72`](https://gi
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12404#issuecomment-210647651
Fair enough. We can revisit if more estimators use the param, or if we add
minTF to HashingTF.
On Fri, 15 Apr 2016 at 22:54, jkbradley wrote:
> I prefer
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/12404#issuecomment-210642641
I prefer to keep them separate. There isn't much benefit to combining 2
instances, and the doc becomes a bit less clear.
---
If your project is set up for it, you c
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/12404#issuecomment-210641271
Sure that sounds like a clearer docstring :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12404#issuecomment-210632010
ah - sorry I missed that. Ok, yeah this makes sense if we unify the doc
string appropriately. Perhaps something like `If true, all non-zero counts
(after any filters are
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/12404#issuecomment-210617504
So I thought the unified doc string of:
> If true, all non zero results are set to 1. This is useful for discrete
probabilistic models that model binary events
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/12404#discussion_r59931924
--- Diff: python/pyspark/ml/param/shared.py ---
@@ -583,6 +583,31 @@ def getVarianceCol(self):
return self.getOrDefault(self.varianceCol)
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12404#issuecomment-210307663
Hey @holdenk, in
https://github.com/apache/spark/pull/12079#issuecomment-209049583 and
https://github.com/apache/spark/pull/12308#issuecomment-209039855, we decided
to
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12404#discussion_r59826196
--- Diff: python/pyspark/ml/param/shared.py ---
@@ -583,6 +583,31 @@ def getVarianceCol(self):
return self.getOrDefault(self.varianceCol)
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12404#issuecomment-210225967
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12404#issuecomment-210225966
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12404#issuecomment-210225853
**[Test build #55872 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55872/consoleFull)**
for PR 12404 at commit
[`edbd652`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12404#issuecomment-210212321
**[Test build #55872 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55872/consoleFull)**
for PR 12404 at commit
[`edbd652`](https://gi
GitHub user holdenk opened a pull request:
https://github.com/apache/spark/pull/12404
[SPARK-14644][ML][PYSPARK] Turn Binary param into a shared param
## What changes were proposed in this pull request?
Change the binary param into a shared param.
## How was this pa
19 matches
Mail list logo
