Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12433
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12433#issuecomment-212034603
Merging in master. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user sameeragarwal commented on the pull request:
https://github.com/apache/spark/pull/12433#issuecomment-212033047
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12433#discussion_r60180864
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -802,7 +807,12 @@ private[spark] class BlockManager(
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12433#discussion_r60180666
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -260,7 +260,12 @@ private[spark] class BlockManager(
def
Github user ScrapCodes commented on a diff in the pull request:
https://github.com/apache/spark/pull/12433#discussion_r60173470
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -260,7 +260,12 @@ private[spark] class BlockManager(
def
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12433#issuecomment-211679436
cc @sameeragarwal for review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12433#issuecomment-211659107
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12433#issuecomment-211659104
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12433#issuecomment-211658925
**[Test build #56154 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56154/consoleFull)**
for PR 12433 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12433#issuecomment-211633603
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12433#issuecomment-211633597
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12433#issuecomment-211633467
**[Test build #56145 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56145/consoleFull)**
for PR 12433 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12433#issuecomment-211620068
**[Test build #56154 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56154/consoleFull)**
for PR 12433 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12433#issuecomment-211598606
**[Test build #56145 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56145/consoleFull)**
for PR 12433 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12433#issuecomment-211597667
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12433#issuecomment-211597673
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12433#issuecomment-211597659
**[Test build #56144 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56144/consoleFull)**
for PR 12433 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12433#issuecomment-211597299
**[Test build #56144 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56144/consoleFull)**
for PR 12433 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12433#issuecomment-211590743
**[Test build #56139 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56139/consoleFull)**
for PR 12433 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12433#issuecomment-211590753
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12433#issuecomment-211590758
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12433#issuecomment-211589994
**[Test build #56139 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56139/consoleFull)**
for PR 12433 at commit
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/12433#issuecomment-211589074
Alright, I've updated this to add a `ThreadUtils.awaitResult` and added a
linter rule to ban direct use of `Await.result`.
---
If your project is set up for it, you
Github user thunterdb commented on the pull request:
https://github.com/apache/spark/pull/12433#issuecomment-211493984
+1, because we can then add a linter rule that disallows `Await.result`
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12433#issuecomment-210876468
Maybe instead of doing this, we should create a wrapper function that wraps
around await.result?
---
If your project is set up for it, you can reply to this email and
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12433#discussion_r59972246
--- Diff:
core/src/main/scala/org/apache/spark/network/BlockTransferService.scala ---
@@ -101,7 +102,12 @@ abstract class BlockTransferService extends
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/12433#issuecomment-210725264
Hmm, this is unfortunate. It looks like there are a bunch more assertions
like the one in the `FutureAction` test suite which match on the class / name
of the
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12433#issuecomment-210721724
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12433#issuecomment-210721722
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12433#issuecomment-210721684
**[Test build #55985 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55985/consoleFull)**
for PR 12433 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12433#issuecomment-210701963
**[Test build #55985 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55985/consoleFull)**
for PR 12433 at commit
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/12433#issuecomment-210701761
I've decided to just leave the occurrence in `FutureAction` untouched for
now.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/12433#issuecomment-210700398
Hmm, those are legitimate test failures. The problem was that wrapping
something in `Exception` changed the exception matched by some test asserts.
---
If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12433#issuecomment-210699178
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12433#issuecomment-210699179
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12433#issuecomment-210699113
**[Test build #55972 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55972/consoleFull)**
for PR 12433 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12433#issuecomment-210676479
**[Test build #55972 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55972/consoleFull)**
for PR 12433 at commit
GitHub user JoshRosen opened a pull request:
https://github.com/apache/spark/pull/12433
[SPARK-14676] Wrap and re-throw Await.result exceptions in order to capture
full stacktrace
When `Await.result` throws an exception which originated from a different
thread, the resulting
39 matches
Mail list logo
