[GitHub] spark pull request: [SPARK-14732][ML] spark.ml GaussianMixture sho...

2016-04-29 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/12593#issuecomment-215884375 Will do, thanks for pinging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-14732][ML] spark.ml GaussianMixture sho...

2016-04-28 Thread dbtsai
Github user dbtsai commented on the pull request: https://github.com/apache/spark/pull/12593#issuecomment-215588256 @jkbradley The `@Since` annotation was merged https://github.com/apache/spark/pull/12416 Could you submit a followup PR? Thanks. --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-14732][ML] spark.ml GaussianMixture sho...

2016-04-27 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/12593#issuecomment-215160693 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] spark pull request: [SPARK-14732][ML] spark.ml GaussianMixture sho...

2016-04-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12593 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-14732][ML] spark.ml GaussianMixture sho...

2016-04-26 Thread dbtsai
Github user dbtsai commented on the pull request: https://github.com/apache/spark/pull/12593#issuecomment-214923459 LGTM. Merged into master. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] spark pull request: [SPARK-14732][ML] spark.ml GaussianMixture sho...

2016-04-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12593#issuecomment-214873998 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14732][ML] spark.ml GaussianMixture sho...

2016-04-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12593#issuecomment-214874003 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14732][ML] spark.ml GaussianMixture sho...

2016-04-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12593#issuecomment-214873844 **[Test build #57020 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57020/consoleFull)** for PR 12593 at commit [`3e5f58b`](https://g

[GitHub] spark pull request: [SPARK-14732][ML] spark.ml GaussianMixture sho...

2016-04-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12593#issuecomment-214863178 **[Test build #57020 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57020/consoleFull)** for PR 12593 at commit [`3e5f58b`](https://gi

[GitHub] spark pull request: [SPARK-14732][ML] spark.ml GaussianMixture sho...

2016-04-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12593#issuecomment-214859907 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14732][ML] spark.ml GaussianMixture sho...

2016-04-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12593#issuecomment-214859909 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14732][ML] spark.ml GaussianMixture sho...

2016-04-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12593#issuecomment-214859863 **[Test build #57017 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57017/consoleFull)** for PR 12593 at commit [`d9901f7`](https://g

[GitHub] spark pull request: [SPARK-14732][ML] spark.ml GaussianMixture sho...

2016-04-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12593#issuecomment-214851129 **[Test build #57017 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57017/consoleFull)** for PR 12593 at commit [`d9901f7`](https://gi

[GitHub] spark pull request: [SPARK-14732][ML] spark.ml GaussianMixture sho...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12593#issuecomment-214560608 **[Test build #56940 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56940/consoleFull)** for PR 12593 at commit [`50e5d1c`](https://g

[GitHub] spark pull request: [SPARK-14732][ML] spark.ml GaussianMixture sho...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12593#issuecomment-214560616 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14732][ML] spark.ml GaussianMixture sho...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12593#issuecomment-214560612 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14732][ML] spark.ml GaussianMixture sho...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12593#issuecomment-214560392 **[Test build #56940 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56940/consoleFull)** for PR 12593 at commit [`50e5d1c`](https://gi

[GitHub] spark pull request: [SPARK-14732][ML] spark.ml GaussianMixture sho...

2016-04-25 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/12593#issuecomment-214559694 Updated, thanks! I'll do the Since annotation later --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] spark pull request: [SPARK-14732][ML] spark.ml GaussianMixture sho...

2016-04-25 Thread dbtsai
Github user dbtsai commented on the pull request: https://github.com/apache/spark/pull/12593#issuecomment-214543499 Do you want to add the test code for both `MultivariateGaussian.scala` and `Utils.scala`? --- If your project is set up for it, you can reply to this email and have you

[GitHub] spark pull request: [SPARK-14732][ML] spark.ml GaussianMixture sho...

2016-04-25 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/12593#discussion_r60996366 --- Diff: mllib-local/src/main/scala/org/apache/spark/ml/stat/distribution/MultivariateGaussian.scala --- @@ -0,0 +1,131 @@ +/* + * Licensed to the A

[GitHub] spark pull request: [SPARK-14732][ML] spark.ml GaussianMixture sho...

2016-04-25 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/12593#discussion_r60996174 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/GaussianMixture.scala --- @@ -17,17 +17,19 @@ package org.apache.spark.ml.clustering

[GitHub] spark pull request: [SPARK-14732][ML] spark.ml GaussianMixture sho...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12593#issuecomment-214494498 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14732][ML] spark.ml GaussianMixture sho...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12593#issuecomment-214494500 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14732][ML] spark.ml GaussianMixture sho...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12593#issuecomment-214494351 **[Test build #56912 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56912/consoleFull)** for PR 12593 at commit [`98f398c`](https://g

[GitHub] spark pull request: [SPARK-14732][ML] spark.ml GaussianMixture sho...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12593#issuecomment-214478040 **[Test build #56912 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56912/consoleFull)** for PR 12593 at commit [`98f398c`](https://gi

[GitHub] spark pull request: [SPARK-14732][ML] spark.ml GaussianMixture sho...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12593#issuecomment-214471645 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14732][ML] spark.ml GaussianMixture sho...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12593#issuecomment-214471646 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14732][ML] spark.ml GaussianMixture sho...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12593#issuecomment-214471592 **[Test build #56906 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56906/consoleFull)** for PR 12593 at commit [`3d310f2`](https://g

[GitHub] spark pull request: [SPARK-14732][ML] spark.ml GaussianMixture sho...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12593#issuecomment-214464159 **[Test build #56906 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56906/consoleFull)** for PR 12593 at commit [`3d310f2`](https://gi

[GitHub] spark pull request: [SPARK-14732][ML] spark.ml GaussianMixture sho...

2016-04-25 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/12593#issuecomment-214463944 CC: @dbtsai Making you aware of this since it touches mllib-local --- If your project is set up for it, you can reply to this email and have your reply appear on GitH