[GitHub] spark pull request: [SPARK-14806] [SQL] Alias original Hive option...

2016-04-26 Thread bomeng
Github user bomeng closed the pull request at: https://github.com/apache/spark/pull/12607 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-14806] [SQL] Alias original Hive option...

2016-04-26 Thread bomeng
Github user bomeng commented on the pull request: https://github.com/apache/spark/pull/12607#issuecomment-214958322 closing it. thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-14806] [SQL] Alias original Hive option...

2016-04-26 Thread bomeng
Github user bomeng commented on the pull request: https://github.com/apache/spark/pull/12607#issuecomment-214818178 @rxin I am open to your decision. I think it is still useful to allow user to use "SET" command by using spark.sql.variable.substitute as configuration. Currently, the "

[GitHub] spark pull request: [SPARK-14806] [SQL] Alias original Hive option...

2016-04-25 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12607#issuecomment-214609204 Hi @bomeng - thanks for doing this. I thought about it more and actually think maybe it's not worth it to support these aliases, because it is going to be confusing when

[GitHub] spark pull request: [SPARK-14806] [SQL] Alias original Hive option...

2016-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12607#issuecomment-213633883 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14806] [SQL] Alias original Hive option...

2016-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12607#issuecomment-213633885 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14806] [SQL] Alias original Hive option...

2016-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12607#issuecomment-213633472 **[Test build #56748 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56748/consoleFull)** for PR 12607 at commit [`b7fb369`](https://g

[GitHub] spark pull request: [SPARK-14806] [SQL] Alias original Hive option...

2016-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12607#issuecomment-213617225 **[Test build #56748 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56748/consoleFull)** for PR 12607 at commit [`b7fb369`](https://gi

[GitHub] spark pull request: [SPARK-14806] [SQL] Alias original Hive option...

2016-04-22 Thread bomeng
Github user bomeng commented on the pull request: https://github.com/apache/spark/pull/12607#issuecomment-213614415 I think you mean set the value of `spark.sql.variable.substitute` and read `spark.sql.variable.substitute` above. I will post another try shortly. --- If your project i

[GitHub] spark pull request: [SPARK-14806] [SQL] Alias original Hive option...

2016-04-22 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12607#issuecomment-213579723 @bomeng maybe i wasn't clear. the goal is: whenever hive.variable.substitute is set by the user, just set the value of hive.variable.substitute; whenever hive.vari

[GitHub] spark pull request: [SPARK-14806] [SQL] Alias original Hive option...

2016-04-22 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12607#discussion_r60798993 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -471,12 +471,24 @@ object SQLConf { .booleanConf .cre

[GitHub] spark pull request: [SPARK-14806] [SQL] Alias original Hive option...

2016-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12607#issuecomment-213566065 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14806] [SQL] Alias original Hive option...

2016-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12607#issuecomment-213566059 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14806] [SQL] Alias original Hive option...

2016-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12607#issuecomment-213565923 **[Test build #56717 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56717/consoleFull)** for PR 12607 at commit [`01cc7d4`](https://g