Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12596
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-215631602
LGTM
Merging with master
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user zhengruifeng commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-215286372
@jkbradley ok, the doc for regparam is updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-215277302
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-215277300
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-215277208
**[Test build #57195 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57195/consoleFull)**
for PR 12596 at commit
[`ee70a7b`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-215271481
**[Test build #57195 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57195/consoleFull)**
for PR 12596 at commit
[`ee70a7b`](https://gi
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/12596#discussion_r61337646
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/Lasso.scala ---
@@ -85,7 +85,8 @@ object LassoModel extends Loader[LassoModel] {
* S
Github user zhengruifeng commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-214983840
@yanboliang Thanks. I have added the doc for regParam.
cc @jkbradley
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-214922109
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-214922022
**[Test build #57045 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57045/consoleFull)**
for PR 12596 at commit
[`6243d92`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-214922108
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-214921317
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-214921321
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-214920972
**[Test build #57044 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57044/consoleFull)**
for PR 12596 at commit
[`4c92ff1`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-214914603
**[Test build #57045 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57045/consoleFull)**
for PR 12596 at commit
[`6243d92`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-214913744
**[Test build #57044 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57044/consoleFull)**
for PR 12596 at commit
[`4c92ff1`](https://gi
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-214844149
@yanboliang 's suggestion sounds good. Other than that, this looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12596#discussion_r61107909
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/RidgeRegression.scala ---
@@ -86,6 +86,7 @@ object RidgeRegressionModel extends
Loader[R
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12596#discussion_r61107833
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/Lasso.scala ---
@@ -85,6 +85,7 @@ object LassoModel extends Loader[LassoModel] {
*
Github user zhengruifeng commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-214695750
@jkbradley I have updated this PR according to your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-214695459
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-214695461
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-214695363
**[Test build #56993 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56993/consoleFull)**
for PR 12596 at commit
[`7601bc4`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-214686935
**[Test build #56993 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56993/consoleFull)**
for PR 12596 at commit
[`7601bc4`](https://gi
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-214495321
Thanks for the PR. This should also include:
* LassoWithSGD (recommend using LinearRegression with elasticNetParam = 1.0)
* RidgeRegressionWithSGD (recommend u
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/12596#discussion_r60974980
--- Diff: python/pyspark/mllib/classification.py ---
@@ -312,6 +313,10 @@ def train(cls, data, iterations=100, step=1.0,
miniBatchFraction=1.0,
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-213245798
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-213245800
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-213245748
**[Test build #56645 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56645/consoleFull)**
for PR 12596 at commit
[`f6d381b`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-213233110
**[Test build #56645 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56645/consoleFull)**
for PR 12596 at commit
[`f6d381b`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-213232740
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-213232739
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-213232736
**[Test build #56644 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56644/consoleFull)**
for PR 12596 at commit
[`9877c7d`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-213232588
**[Test build #56644 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56644/consoleFull)**
for PR 12596 at commit
[`9877c7d`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-213230211
**[Test build #56642 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56642/consoleFull)**
for PR 12596 at commit
[`94913d5`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-213230214
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-213230212
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-213229967
**[Test build #56642 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56642/consoleFull)**
for PR 12596 at commit
[`94913d5`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-213227583
**[Test build #56640 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56640/consoleFull)**
for PR 12596 at commit
[`7bd7e41`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-213227588
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-213227585
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-213227407
**[Test build #56640 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56640/consoleFull)**
for PR 12596 at commit
[`7bd7e41`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-213225874
**[Test build #56638 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56638/consoleFull)**
for PR 12596 at commit
[`1a1d9e0`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-213225883
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-213225879
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12596#issuecomment-213225250
**[Test build #56638 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56638/consoleFull)**
for PR 12596 at commit
[`1a1d9e0`](https://gi
GitHub user zhengruifeng opened a pull request:
https://github.com/apache/spark/pull/12596
[SPARK-14829][MLLIB] Deprecate GLM APIs using SGD
## What changes were proposed in this pull request?
According to the
[SPARK-14829](https://issues.apache.org/jira/browse/SPARK-14829), dep
48 matches
Mail list logo
