Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/12613#issuecomment-216313536
The host is easy to fix. However, the hard part is `port`. The executor
cannot know the port until it sends a message. In addition, since the executor
runs in the
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/12613#discussion_r61776444
--- Diff: core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala
---
@@ -120,9 +120,15 @@ private[netty] class NettyRpcEnv(
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12613#issuecomment-215147616
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12613#issuecomment-215147612
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12613#issuecomment-215147386
**[Test build #57133 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57133/consoleFull)**
for PR 12613 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12613#issuecomment-215117480
**[Test build #57133 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57133/consoleFull)**
for PR 12613 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12613#issuecomment-215081590
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12613#issuecomment-215081584
**[Test build #57125 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57125/consoleFull)**
for PR 12613 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12613#issuecomment-215081593
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12613#issuecomment-215081239
**[Test build #57125 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57125/consoleFull)**
for PR 12613 at commit
Github user skyluc commented on the pull request:
https://github.com/apache/spark/pull/12613#issuecomment-215080708
Added comments, updated checks for cases when running in client mode,
removed sending back the hostname to the executor.
---
If your project is set up for it, you can
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12613#discussion_r61022118
--- Diff: core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala
---
@@ -122,7 +122,7 @@ private[netty] class NettyRpcEnv(
@Nullable
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12613#discussion_r61022100
--- Diff: core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala
---
@@ -122,7 +122,7 @@ private[netty] class NettyRpcEnv(
@Nullable
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12613#issuecomment-214591914
I think there are also some code in SparkEnv that deals with this?
```
if (isDriver) {
conf.set("spark.driver.port", rpcEnv.address.port.toString)
Github user skyluc commented on the pull request:
https://github.com/apache/spark/pull/12613#issuecomment-214336966
Are the test failures real, or due to flaky tests?
I tried to reproduced the failures locally, but `core/test` passes most of
the time.
---
If your project is set
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12613#issuecomment-213798398
cc @zsxwing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12613#issuecomment-213511310
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12613#issuecomment-213510771
**[Test build #56705 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56705/consoleFull)**
for PR 12613 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12613#issuecomment-213511313
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12613#issuecomment-213471010
**[Test build #56705 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56705/consoleFull)**
for PR 12613 at commit
GitHub user skyluc opened a pull request:
https://github.com/apache/spark/pull/12613
[SPARK-14849][CORE]Always set an address for the executor
As specified in
[SPARK-14849](https://issues.apache.org/jira/browse/SPARK-14849), the `address`
in the `NettyRpcEnv` for the executor is
21 matches
Mail list logo
