Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-222338133
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-222338132
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-222338094
**[Test build #59571 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59571/consoleFull)**
for PR 12618 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-222335855
**[Test build #59571 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59571/consoleFull)**
for PR 12618 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-221138381
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-221138384
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-221138243
**[Test build #59161 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59161/consoleFull)**
for PR 12618 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-221123850
**[Test build #59161 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59161/consoleFull)**
for PR 12618 at commit
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-221123110
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-220758879
**[Test build #59056 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59056/consoleFull)**
for PR 12618 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-220758920
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-220758921
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-220752109
**[Test build #59056 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59056/consoleFull)**
for PR 12618 at commit
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-220751991
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-219325097
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-219325105
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-219325051
**[Test build #58622 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58622/consoleFull)**
for PR 12618 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-219317682
**[Test build #58622 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58622/consoleFull)**
for PR 12618 at commit
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-218660290
@hvanhovell Could you check if the latest changes resolve all your
comments?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-218371328
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-218371327
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-218371154
**[Test build #58325 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58325/consoleFull)**
for PR 12618 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-218360331
**[Test build #58325 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58325/consoleFull)**
for PR 12618 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12618#discussion_r62707458
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -387,6 +445,10 @@ class SessionCatalog(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12618#discussion_r62707441
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -130,19 +158,29 @@ class SessionCatalog(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12618#discussion_r62707415
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -365,7 +421,9 @@ class SessionCatalog(
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12618#discussion_r62642250
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -387,6 +445,10 @@ class SessionCatalog(
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12618#discussion_r6264
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -365,7 +421,9 @@ class SessionCatalog(
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12618#discussion_r62641866
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -130,19 +158,29 @@ class SessionCatalog(
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-218083872
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-218083870
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-218083672
**[Test build #58212 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58212/consoleFull)**
for PR 12618 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-218068414
**[Test build #58212 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58212/consoleFull)**
for PR 12618 at commit
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-218050854
This PR removes `CreateDataSourceTableUtils.validateName`. We move it to
`SessionCatalog`. Let me know if we need to make any change here.
Thanks! @yhuai
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-218048161
Yea, let's be consistent on what we allow for table and db names. We have a
utility function `CreateDataSourceTableUtils.validateName`, which does the same
check as
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-218047607
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-218047605
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-218047473
**[Test build #58194 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58194/consoleFull)**
for PR 12618 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-218036052
**[Test build #58194 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58194/consoleFull)**
for PR 12618 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12618#discussion_r62598343
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -93,6 +95,41 @@ class SessionCatalog(
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12618#discussion_r62598308
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -93,6 +95,41 @@ class SessionCatalog(
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12618#discussion_r62598323
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -93,6 +95,41 @@ class SessionCatalog(
}
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-217952310
> Do we want to restrain all table and database names used in a catalog to
just alphanumeric characters and underscores? Or just those we use in the Hive
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-217952164
Looks OK
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12618#discussion_r62550699
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -93,6 +95,41 @@ class SessionCatalog(
}
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12618#discussion_r62550663
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -93,6 +95,41 @@ class SessionCatalog(
}
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12618#discussion_r62550588
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -93,6 +95,41 @@ class SessionCatalog(
}
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-217561687
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-217561689
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-217561447
**[Test build #58024 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58024/consoleFull)**
for PR 12618 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-217542372
**[Test build #58024 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58024/consoleFull)**
for PR 12618 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-214948316
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-214948315
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-214948104
**[Test build #57065 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57065/consoleFull)**
for PR 12618 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-214931161
**[Test build #57065 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57065/consoleFull)**
for PR 12618 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-214163999
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-214164002
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-214163860
**[Test build #56880 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56880/consoleFull)**
for PR 12618 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-214132079
**[Test build #56880 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56880/consoleFull)**
for PR 12618 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-214120098
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-214120097
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-214119972
**[Test build #56869 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56869/consoleFull)**
for PR 12618 at commit
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-214100950
@hvanhovell @yhuai I hit and address a related issue.
Running SQL on files directly could break the rules. For example,
```SQL
select id from
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-214100543
**[Test build #56869 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56869/consoleFull)**
for PR 12618 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12618#discussion_r60846156
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala ---
@@ -75,6 +77,33 @@ private[sql] class HiveSessionCatalog(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12618#discussion_r60846142
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala ---
@@ -75,6 +77,33 @@ private[sql] class HiveSessionCatalog(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12618#discussion_r60846069
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -78,29 +78,66 @@ class SessionCatalog(
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-213946062
@gatorsmile this looks pretty solid. I have one question though. Do we want
to restrain all table and database names used in a catalog to just alphanumeric
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12618#discussion_r60842895
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala ---
@@ -75,6 +77,33 @@ private[sql] class HiveSessionCatalog(
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12618#discussion_r60842896
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala ---
@@ -75,6 +77,33 @@ private[sql] class HiveSessionCatalog(
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12618#discussion_r60842882
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala ---
@@ -75,6 +77,33 @@ private[sql] class HiveSessionCatalog(
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12618#discussion_r60842867
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -78,29 +78,66 @@ class SessionCatalog(
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12618#discussion_r60842416
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -78,29 +78,66 @@ class SessionCatalog(
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-213756370
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-213756371
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-213756118
**[Test build #56800 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56800/consoleFull)**
for PR 12618 at commit
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-213743088
@hvanhovell It is ready to review. Thanks!
This is partially related to what we discussed in
https://github.com/apache/spark/pull/12537
---
If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-213743041
**[Test build #56800 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56800/consoleFull)**
for PR 12618 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12618#discussion_r60828506
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -78,29 +78,66 @@ class SessionCatalog(
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-213678648
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-213678647
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-213678602
**[Test build #56781 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56781/consoleFull)**
for PR 12618 at commit
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12618#discussion_r60824241
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -78,29 +78,66 @@ class SessionCatalog(
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12618#discussion_r60824199
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -78,29 +78,66 @@ class SessionCatalog(
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12618#issuecomment-213667639
**[Test build #56781 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56781/consoleFull)**
for PR 12618 at commit
85 matches
Mail list logo
