[GitHub] spark pull request: [SPARK-14865][SQL] Better error handling for v...

2016-04-24 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/12633#discussion_r60839961 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala --- @@ -85,68 +88,74 @@ case class CreateViewCommand( }

[GitHub] spark pull request: [SPARK-14865][SQL] Better error handling for v...

2016-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12633 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14865][SQL] Better error handling for v...

2016-04-23 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12633#issuecomment-213823889 LGTM. Merging to master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-14865][SQL] Better error handling for v...

2016-04-23 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12633#discussion_r60832575 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala --- @@ -85,68 +88,74 @@ case class CreateViewCommand( } else {

[GitHub] spark pull request: [SPARK-14865][SQL] Better error handling for v...

2016-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12633#issuecomment-213692703 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14865][SQL] Better error handling for v...

2016-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12633#issuecomment-213692704 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14865][SQL] Better error handling for v...

2016-04-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12633#issuecomment-213692659 **[Test build #56786 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56786/consoleFull)** for PR 12633 at commit

[GitHub] spark pull request: [SPARK-14865][SQL] Better error handling for v...

2016-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12633#issuecomment-213690916 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14865][SQL] Better error handling for v...

2016-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12633#issuecomment-213690917 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14865][SQL] Better error handling for v...

2016-04-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12633#issuecomment-213690865 **[Test build #56785 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56785/consoleFull)** for PR 12633 at commit

[GitHub] spark pull request: [SPARK-14865][SQL] Better error handling for v...

2016-04-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12633#issuecomment-213676984 **[Test build #56786 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56786/consoleFull)** for PR 12633 at commit

[GitHub] spark pull request: [SPARK-14865][SQL] Better error handling for v...

2016-04-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12633#issuecomment-213675764 **[Test build #56785 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56785/consoleFull)** for PR 12633 at commit

[GitHub] spark pull request: [SPARK-14865][SQL] Better error handling for v...

2016-04-23 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12633#issuecomment-213675544 also cc @liancheng who wrote some of the original code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-14865][SQL] Better error handling for v...

2016-04-23 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12633#issuecomment-213675496 cc @gatorsmile --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-14865][SQL] Better error handling for v...

2016-04-23 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/12633 [SPARK-14865][SQL] Better error handling for view creation. ## What changes were proposed in this pull request? This patch improves error handling in view creation. CreateViewCommand itself will