Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12638
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/12638#issuecomment-215159163
Thanks, merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12638#issuecomment-214959647
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12638#issuecomment-214959646
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12638#issuecomment-214959537
**[Test build #57073 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57073/consoleFull)**
for PR 12638 at commit
[`653fa52`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12638#issuecomment-214943338
**[Test build #57073 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57073/consoleFull)**
for PR 12638 at commit
[`653fa52`](https://gi
Github user lw-lin commented on the pull request:
https://github.com/apache/spark/pull/12638#issuecomment-214943354
just rebase to master to resolve some conflicts
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12638#discussion_r61193722
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSource.scala
---
@@ -88,7 +88,7 @@ class FileStreamSource(
}
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12638#issuecomment-214754195
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12638#issuecomment-214754191
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12638#issuecomment-214753843
**[Test build #56996 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56996/consoleFull)**
for PR 12638 at commit
[`14e6900`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12638#issuecomment-214715775
**[Test build #56996 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56996/consoleFull)**
for PR 12638 at commit
[`14e6900`](https://gi
Github user lw-lin commented on the pull request:
https://github.com/apache/spark/pull/12638#issuecomment-214714643
Jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user lw-lin commented on the pull request:
https://github.com/apache/spark/pull/12638#issuecomment-214609215
some build issues unrelated to this PR.
Jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12638#issuecomment-214607395
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12638#issuecomment-214607393
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12638#issuecomment-214607377
**[Test build #56957 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56957/consoleFull)**
for PR 12638 at commit
[`14e6900`](https://g
Github user lw-lin commented on the pull request:
https://github.com/apache/spark/pull/12638#issuecomment-214606875
@marmbrus thanks for the patient reminder!
Since I've reverted the renaming, and I've checked there's no other
completely unused class under `o.a.s.sql.execution
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12638#issuecomment-214606829
**[Test build #56957 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56957/consoleFull)**
for PR 12638 at commit
[`14e6900`](https://gi
GitHub user lw-lin reopened a pull request:
https://github.com/apache/spark/pull/12638
[SPARK-14874][SQL][Streaming] Remove the obsolete Batch representation
## What changes were proposed in this pull request?
The `Batch` class, which had been used to indicate progress in a
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/12638#issuecomment-214597468
To be clear, if there's a completely unused class, I think it's worth the
time to delete it (dead code is confusing for people trying to learn the
code base).
Github user lw-lin commented on the pull request:
https://github.com/apache/spark/pull/12638#issuecomment-214586964
Sure, so I'm closing this PR since the removal itself is not worthy for
committers to process.
@marmbrus thanks for the review!
---
If your project is set up for it
Github user lw-lin closed the pull request at:
https://github.com/apache/spark/pull/12638
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/12638#issuecomment-214460285
It's fine to remove the class, but lets avoid unneeded renaming.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/12638#discussion_r60957003
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSink.scala
---
@@ -47,7 +47,7 @@ class FileStreamSink(
private
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12638#issuecomment-213879726
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12638#issuecomment-213879728
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12638#issuecomment-213879699
**[Test build #56824 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56824/consoleFull)**
for PR 12638 at commit
[`c79cba9`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12638#issuecomment-213870648
**[Test build #56824 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56824/consoleFull)**
for PR 12638 at commit
[`c79cba9`](https://gi
Github user lw-lin commented on the pull request:
https://github.com/apache/spark/pull/12638#issuecomment-213870571
@marmbrus @tdas would you mind taking a look? Thanks! :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
GitHub user lw-lin reopened a pull request:
https://github.com/apache/spark/pull/12638
[SPARK-14874][SQL][Streaming] Remove the obsolete Batch representation
## What changes were proposed in this pull request?
The `Batch` class, which had been used to indicate progress in a
31 matches
Mail list logo
