Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4934
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/4934#issuecomment-125656909
We refactored the implementation. You can find the latest version at
https://github.com/databricks/spark-tfocs. We will send a new PR when the
implementation is ready.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4934#issuecomment-125644133
Likewise is this one stale? I'm not sure this is going to move forward.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user staple commented on a diff in the pull request:
https://github.com/apache/spark/pull/4934#discussion_r26186113
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/optimization/AcceleratedGradientDescent.scala
---
@@ -0,0 +1,237 @@
+/*
+ * Licensed to the Apac
Github user staple commented on the pull request:
https://github.com/apache/spark/pull/4934#issuecomment-78192837
Hi, replying to some of the statements above:
> It seems @staple has already implemented backtracking (because he has
results in the JIRA), but kept them out of th
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/4934#issuecomment-78165360
Line search helps if you don't know the Lipschitz constant. With
accelerated gradient, it is very easy to blow up if the step size is wrong. I'm
okay with not having line
Github user rezazadeh commented on the pull request:
https://github.com/apache/spark/pull/4934#issuecomment-77801646
Thank you for this PR @staple !
@mengxr I suggested to @staple to first implement without backtracking to
keep the PR as simple as possible. According to his pl
Github user staple commented on a diff in the pull request:
https://github.com/apache/spark/pull/4934#discussion_r25986928
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/optimization/AcceleratedGradientDescent.scala
---
@@ -0,0 +1,237 @@
+/*
+ * Licensed to the Apac
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/4934#discussion_r25985578
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/optimization/AcceleratedGradientDescent.scala
---
@@ -0,0 +1,237 @@
+/*
+ * Licensed to the Apac
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4934#issuecomment-77638297
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4934#issuecomment-77638281
[Test build #28355 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28355/consoleFull)
for PR 4934 at commit
[`a121bd0`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4934#issuecomment-77625694
[Test build #28355 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28355/consoleFull)
for PR 4934 at commit
[`a121bd0`](https://githu
GitHub user staple opened a pull request:
https://github.com/apache/spark/pull/4934
[SPARK-1503][MLLIB] Initial AcceleratedGradientDescent implementation.
An implementation of accelerated gradient descent, a first order
optimization algorithm with faster asymptotic convergence than
13 matches
Mail list logo
