Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13135
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/13135#issuecomment-220241901
LGTM too. Merged to master/branch-2.0. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13135#issuecomment-220223044
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13135#issuecomment-220223043
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13135#issuecomment-220222980
**[Test build #58838 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58838/consoleFull)**
for PR 13135 at commit
[`9ec58e6`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13135#issuecomment-220222031
**[Test build #58838 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58838/consoleFull)**
for PR 13135 at commit
[`9ec58e6`](https://gi
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/13135#issuecomment-220009767
I see. Thanks! I will change them tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/13135#issuecomment-22072
One minor issue: Since we changed ```thresholds`` at Python example to
```[0.5, 0.5]```, should we also update Scala/Java examples to make them
consistent. Although
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13135#issuecomment-219926751
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13135#issuecomment-219926703
**[Test build #58745 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58745/consoleFull)**
for PR 13135 at commit
[`bb88635`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13135#issuecomment-219926748
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13135#issuecomment-219925856
**[Test build #58745 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58745/consoleFull)**
for PR 13135 at commit
[`bb88635`](https://gi
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/13135#discussion_r63644923
--- Diff: examples/src/main/python/ml/simple_params_example.py ---
@@ -36,18 +35,20 @@
if len(sys.argv) > 1:
--- End diff --
Thank y
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/13135#discussion_r63643565
--- Diff: examples/src/main/python/ml/simple_params_example.py ---
@@ -36,18 +35,20 @@
if len(sys.argv) > 1:
--- End diff --
We're moving
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/13135#issuecomment-219922114
@HyukjinKwon ah right, of course. I forgot the params get set during `fit`
in Python.
---
If your project is set up for it, you can reply to this email and have your
re
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/13135#discussion_r63640828
--- Diff: examples/src/main/python/ml/simple_params_example.py ---
@@ -36,18 +35,20 @@
if len(sys.argv) > 1:
--- End diff --
@yanbol
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/13135#discussion_r63640687
--- Diff: examples/src/main/python/ml/simple_params_example.py ---
@@ -36,18 +35,20 @@
if len(sys.argv) > 1:
--- End diff --
I see..
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13135#discussion_r63638842
--- Diff: examples/src/main/python/ml/simple_params_example.py ---
@@ -36,18 +35,20 @@
if len(sys.argv) > 1:
--- End diff --
This c
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/13135#discussion_r63638465
--- Diff: examples/src/main/python/ml/simple_params_example.py ---
@@ -36,18 +35,20 @@
if len(sys.argv) > 1:
--- End diff --
Hm.. Is
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/13135#discussion_r63638222
--- Diff: examples/src/main/python/ml/simple_params_example.py ---
@@ -36,18 +35,20 @@
if len(sys.argv) > 1:
--- End diff --
It see
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/13135#issuecomment-219876620
@MLnick Yes. It seems `threshold` and `thresholds` are set exclusively via
`set..` methods but in Python both can be set via `fit` method.
---
If your project is s
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/13135#issuecomment-219809983
This looks ok - though the Scala example doesn't throw the exception - why
is that (since it is also setting `thresholds`)?
---
If your project is set up for it, you ca
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/13135#issuecomment-219569749
@yanboliang Thank you so much for taking a close look and a detailed
explanation!
---
If your project is set up for it, you can reply to this email and have your
r
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/13135#issuecomment-219465927
This looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/13135#discussion_r63374755
--- Diff: examples/src/main/python/ml/simple_params_example.py ---
@@ -70,18 +71,18 @@
# We may alternatively specify parameters using a par
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/13135#issuecomment-219419054
(Please let me leave a link I usually refer.
https://github.com/databricks/scala-style-guide)
---
If your project is set up for it, you can reply to this email and
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/13135#issuecomment-219405542
Could you please take a look? @MLnick
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13135#issuecomment-219404033
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13135#issuecomment-219403972
**[Test build #58638 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58638/consoleFull)**
for PR 13135 at commit
[`fc49d30`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13135#issuecomment-219404031
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13135#issuecomment-219402895
**[Test build #58638 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58638/consoleFull)**
for PR 13135 at commit
[`fc49d30`](https://gi
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/13135
[SPARK-15031][EXAMPLES][FOLLOW-UP] Make Python param example working with
SparkSession
## What changes were proposed in this pull request?
It seems most of Python examples were changed
32 matches
Mail list logo
