Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12851
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12851#issuecomment-217286838
Merging into master 2.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12851#issuecomment-217250400
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12851#issuecomment-217250399
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12851#issuecomment-217250125
**[Test build #57904 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57904/consoleFull)**
for PR 12851 at commit
[`5e464ad`](https://g
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12851#issuecomment-217249543
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12851#issuecomment-217225199
**[Test build #57904 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57904/consoleFull)**
for PR 12851 at commit
[`5e464ad`](https://gi
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12851#issuecomment-217216308
@techaddict this is getting really close. For the regression test for
SPARK-8489 I would just fix it later since this patch doesn't rebuild that jar
anyway.
---
If
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12851#discussion_r62220691
--- Diff:
examples/src/main/scala/org/apache/spark/examples/sql/hive/HiveFromSpark.scala
---
@@ -36,13 +36,14 @@ object HiveFromSpark {
def
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12851#discussion_r62220547
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala ---
@@ -290,8 +290,9 @@ object SetWarehouseLocationTest extends Log
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12851#discussion_r62220387
--- Diff: sql/hive/src/test/resources/regression-test-SPARK-8489/Main.scala
---
@@ -33,8 +33,14 @@ object Main {
def main(args: Array[String]) {
Github user techaddict commented on the pull request:
https://github.com/apache/spark/pull/12851#issuecomment-217096326
@rxin @andrewor14 Comments Addressed, now all tests are passing ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12851#issuecomment-217095292
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12851#issuecomment-217095294
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12851#issuecomment-217095172
**[Test build #57849 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57849/consoleFull)**
for PR 12851 at commit
[`7ad494d`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12851#issuecomment-217083534
**[Test build #57849 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57849/consoleFull)**
for PR 12851 at commit
[`7ad494d`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12851#issuecomment-217049798
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12851#issuecomment-217049795
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12851#issuecomment-217049712
**[Test build #57812 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57812/consoleFull)**
for PR 12851 at commit
[`17e0703`](https://g
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12851#issuecomment-217048754
@techaddict a general point is to try to get the `SparkContext` from the
`SparkSession` rather than the other way round. Right now we call
`getOrCreate()` and assume
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12851#discussion_r62137560
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLEnv.scala
---
@@ -55,7 +55,7 @@ private[hive] object SparkS
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12851#discussion_r62137580
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLEnv.scala
---
@@ -55,7 +55,7 @@ private[hive] object SparkS
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12851#discussion_r62137474
--- Diff:
repl/scala-2.10/src/main/scala/org/apache/spark/repl/SparkILoop.scala ---
@@ -1023,7 +1023,7 @@ class SparkILoop(
val builder = SparkSe
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12851#discussion_r62137462
--- Diff: repl/scala-2.11/src/main/scala/org/apache/spark/repl/Main.scala
---
@@ -89,7 +89,7 @@ object Main extends Logging {
val builder =
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12851#issuecomment-217027622
**[Test build #57812 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57812/consoleFull)**
for PR 12851 at commit
[`17e0703`](https://gi
Github user techaddict commented on the pull request:
https://github.com/apache/spark/pull/12851#issuecomment-216924431
@rxin yupp failed tests are in sql hive tests, waiting for
https://github.com/apache/spark/pull/12890
---
If your project is set up for it, you can reply to this e
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12851#issuecomment-216667688
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12851#issuecomment-216667685
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12851#issuecomment-216667457
**[Test build #57656 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57656/consoleFull)**
for PR 12851 at commit
[`7a07671`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12851#issuecomment-216630447
**[Test build #57656 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57656/consoleFull)**
for PR 12851 at commit
[`7a07671`](https://gi
Github user techaddict commented on the pull request:
https://github.com/apache/spark/pull/12851#issuecomment-216628798
Jenkins retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12851#issuecomment-216625171
Seems like some legitimate failure/?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12851#discussion_r61927456
--- Diff: sql/hive/src/test/resources/regression-test-SPARK-8489/Main.scala
---
@@ -34,7 +34,7 @@ object Main {
// scalastyle:off println
Github user techaddict commented on a diff in the pull request:
https://github.com/apache/spark/pull/12851#discussion_r61898180
--- Diff: sql/hive/src/test/resources/regression-test-SPARK-8489/Main.scala
---
@@ -34,7 +34,7 @@ object Main {
// scalastyle:off println
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12851#issuecomment-216427871
**[Test build #2961 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2961/consoleFull)**
for PR 12851 at commit
[`7a07671`](https://
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12851#issuecomment-216411192
**[Test build #2961 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2961/consoleFull)**
for PR 12851 at commit
[`7a07671`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12851#issuecomment-216410962
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12851#issuecomment-216410883
**[Test build #57569 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57569/consoleFull)**
for PR 12851 at commit
[`7a07671`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12851#issuecomment-216410964
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12851#issuecomment-216403881
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12851#discussion_r61826618
--- Diff: sql/hive/src/test/resources/regression-test-SPARK-8489/Main.scala
---
@@ -34,7 +34,7 @@ object Main {
// scalastyle:off println
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12851#discussion_r61824715
--- Diff: sql/hive/src/test/resources/regression-test-SPARK-8489/Main.scala
---
@@ -34,7 +34,7 @@ object Main {
// scalastyle:off println
prin
Github user techaddict commented on a diff in the pull request:
https://github.com/apache/spark/pull/12851#discussion_r61822413
--- Diff: sql/hive/src/test/resources/regression-test-SPARK-8489/Main.scala
---
@@ -34,7 +34,7 @@ object Main {
// scalastyle:off println
Github user techaddict commented on a diff in the pull request:
https://github.com/apache/spark/pull/12851#discussion_r61821921
--- Diff: sql/hive/src/test/resources/regression-test-SPARK-8489/Main.scala
---
@@ -34,7 +34,7 @@ object Main {
// scalastyle:off println
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12851#discussion_r61821254
--- Diff: sql/hive/src/test/resources/regression-test-SPARK-8489/Main.scala
---
@@ -34,7 +34,7 @@ object Main {
// scalastyle:off println
prin
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12851#issuecomment-216390411
**[Test build #57569 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57569/consoleFull)**
for PR 12851 at commit
[`7a07671`](https://gi
GitHub user techaddict opened a pull request:
https://github.com/apache/spark/pull/12851
[SPARK-15072][SQL][REPL][EXAMPLES] Remove SparkSession.withHiveSupport
## What changes were proposed in this pull request?
Removing the `withHiveSupport` method of `SparkSession`, instead use
47 matches
Mail list logo
