Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216724708
Thank you, @andrewor14 !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12860
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216713413
Thanks, merging into master 2.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216706125
Hi, @davies and @andrewor14 . Now, it's updated.
- Add `stop` in `SparkSession`
- Update builder pattern according to the Scala versions.
- One
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216693879
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216693876
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216693795
**[Test build #57684 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57684/consoleFull)**
for PR 12860 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216692036
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216691977
**[Test build #57683 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57683/consoleFull)**
for PR 12860 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216692033
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216690794
**[Test build #57684 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57684/consoleFull)**
for PR 12860 at commit
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12860#discussion_r61970538
--- Diff: python/pyspark/sql/session.py ---
@@ -58,10 +59,16 @@ def toDF(self, schema=None, sampleRatio=None):
class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216688891
**[Test build #57683 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57683/consoleFull)**
for PR 12860 at commit
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12860#discussion_r61969146
--- Diff: python/pyspark/sql/session.py ---
@@ -58,10 +59,16 @@ def toDF(self, schema=None, sampleRatio=None):
class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12860#discussion_r61968765
--- Diff: python/pyspark/sql/session.py ---
@@ -58,10 +59,16 @@ def toDF(self, schema=None, sampleRatio=None):
class
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-21678
Great! Thank you, @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216663715
It's been merged!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216623388
Thank you, @davies and @andrewor14 .
Ya, it's still evolving! No problem. After merging #12873 , I'll update
accordingly again.
---
If your project is set
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216620498
**[Test build #57649 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57649/consoleFull)**
for PR 12860 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216620530
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12860#discussion_r61930511
--- Diff: python/pyspark/sql/session.py ---
@@ -445,6 +452,86 @@ def read(self):
"""
return DataFrameReader(self._wrapped)
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216620533
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216619217
Looks good otherwise
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12860#discussion_r61929447
--- Diff: python/pyspark/sql/session.py ---
@@ -445,6 +452,77 @@ def read(self):
"""
return DataFrameReader(self._wrapped)
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12860#discussion_r61929305
--- Diff: python/pyspark/sql/session.py ---
@@ -445,6 +452,86 @@ def read(self):
"""
return DataFrameReader(self._wrapped)
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12860#discussion_r61929340
--- Diff: python/pyspark/sql/session.py ---
@@ -445,6 +452,86 @@ def read(self):
"""
return DataFrameReader(self._wrapped)
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12860#discussion_r61929215
--- Diff: python/pyspark/sql/session.py ---
@@ -58,10 +59,16 @@ def toDF(self, schema=None, sampleRatio=None):
class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12860#discussion_r61928851
--- Diff: examples/src/main/python/sql.py ---
@@ -57,24 +52,22 @@
else:
path = sys.argv[1]
# Create a DataFrame from the
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12860#discussion_r61928761
--- Diff: python/pyspark/sql/session.py ---
@@ -445,6 +452,86 @@ def read(self):
"""
return DataFrameReader(self._wrapped)
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216615278
**[Test build #57649 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57649/consoleFull)**
for PR 12860 at commit
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216614939
@davies . I addressed two comments, but I'm not sure about the first one.
We need to change `ScalaSession.Builder` first if we want to change.
---
If your
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216601861
Thank you for review, @davies . I'll update soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12860#discussion_r61842033
--- Diff: python/pyspark/sql/session.py ---
@@ -445,6 +452,77 @@ def read(self):
"""
return DataFrameReader(self._wrapped)
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12860#discussion_r61841998
--- Diff: python/pyspark/sql/session.py ---
@@ -445,6 +452,77 @@ def read(self):
"""
return DataFrameReader(self._wrapped)
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/12860#discussion_r61841944
--- Diff: python/pyspark/sql/session.py ---
@@ -445,6 +452,77 @@ def read(self):
"""
return DataFrameReader(self._wrapped)
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216447685
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216447683
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216447634
**[Test build #57602 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57602/consoleFull)**
for PR 12860 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216445508
**[Test build #57602 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57602/consoleFull)**
for PR 12860 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216435351
**[Test build #57593 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57593/consoleFull)**
for PR 12860 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216435365
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216435366
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216434348
**[Test build #57593 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57593/consoleFull)**
for PR 12860 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216433357
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216433356
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216433350
**[Test build #57592 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57592/consoleFull)**
for PR 12860 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216431710
**[Test build #57592 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57592/consoleFull)**
for PR 12860 at commit
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12860#discussion_r61837000
--- Diff: python/pyspark/sql/session.py ---
@@ -445,6 +446,77 @@ def read(self):
"""
return DataFrameReader(self._wrapped)
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216430921
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216430923
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216430890
**[Test build #57589 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57589/consoleFull)**
for PR 12860 at commit
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12860#discussion_r61836206
--- Diff: python/pyspark/sql/session.py ---
@@ -445,6 +446,77 @@ def read(self):
"""
return DataFrameReader(self._wrapped)
+
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216429783
cc @davies can you take a look at the builder API?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216429563
**[Test build #57589 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57589/consoleFull)**
for PR 12860 at commit
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12860#issuecomment-216429487
@rxin .
This is the initial commit to confirm the direction. Could you give me some
advice?
---
If your project is set up for it, you can reply to this
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/12860
[SPARK-15084][PYTHON][SQL] Use builder pattern to create SparkSession in
PySpark.
## What changes were proposed in this pull request?
This is a python port of corresponding Scala
56 matches
Mail list logo
