Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/12956#issuecomment-218031560
@davies yea, I think so. The evaluation ordering of predicates makes
subexpression elimination more complicated. I will try to simplify it. If it
can't be, I will close
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/12956#issuecomment-217921582
@viirya It's too complicated, we may not do this. I think we will not
support subexpression elimination in most of the operators.
---
If your project is set up for it,
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/12956#issuecomment-217768690
cc @davies This is ready for review. Please take a look of this. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12956#issuecomment-217699205
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12956#issuecomment-217699207
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12956#issuecomment-217699173
**[Test build #58091 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58091/consoleFull)**
for PR 12956 at commit
[`b40fd4b`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12956#issuecomment-217692284
**[Test build #58091 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58091/consoleFull)**
for PR 12956 at commit
[`b40fd4b`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12956#issuecomment-217690214
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12956#issuecomment-217690194
**[Test build #58083 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58083/consoleFull)**
for PR 12956 at commit
[`ff1b7d0`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12956#issuecomment-217690215
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12956#issuecomment-217688141
**[Test build #58083 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58083/consoleFull)**
for PR 12956 at commit
[`ff1b7d0`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12956#issuecomment-217474807
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12956#issuecomment-217474810
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12956#issuecomment-217474554
**[Test build #57997 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57997/consoleFull)**
for PR 12956 at commit
[`55e43ef`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12956#issuecomment-217457647
**[Test build #57997 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57997/consoleFull)**
for PR 12956 at commit
[`55e43ef`](https://gi
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/12956#issuecomment-217456943
Codes:
val ds = Seq(("a", 10), ("a", 20), ("b", 1), ("b", 2), ("c",
1)).toDS().filter("_2 + 1 > 5").filter("_2 + 1 > 20")
ds.collect()
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/12956
[SPARK-15180][SQL] Support subexpression elimination in Fliter
## What changes were proposed in this pull request?
This patch tries to add the support of subexpression elimination in
wholes
17 matches
Mail list logo
