Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/13041#issuecomment-218581276
Also, once you fix those can you add [SPARK-15274] to the title?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/13041#issuecomment-218580402
The only changes I would suggest here are:
(1) Change the condition to `value == null || value.isEmpty || value ==
csvOptions.nullValue`
(2) Renaming `C0` to
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13041#discussion_r62920728
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/DefaultSource.scala
---
@@ -61,7 +61,9 @@ class DefaultSource extends Fi
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/13041#issuecomment-218579388
@HyukjinKwon I think we should rename both null and empty strings. In both
cases there's no way to query the column. Also I looked at the other two
patches and altho
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/13041#discussion_r62793802
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/DefaultSource.scala
---
@@ -61,7 +61,9 @@ class DefaultSource extends F
Github user anabranch commented on a diff in the pull request:
https://github.com/apache/spark/pull/13041#discussion_r62793571
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/DefaultSource.scala
---
@@ -61,7 +61,9 @@ class DefaultSource extends Fil
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/13041#issuecomment-218363294
@anabranch First of all, I think currently (at least for me) it is really
confusing to deal with `null`, `""` and empty string in CSV. I am trying to
make this clea
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/13041#discussion_r62792044
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/DefaultSource.scala
---
@@ -61,7 +61,9 @@ class DefaultSource extends F
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13041#issuecomment-218357313
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13041#issuecomment-218357314
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13041#issuecomment-218357216
**[Test build #58315 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58315/consoleFull)**
for PR 13041 at commit
[`85d0843`](https://g
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/13041#issuecomment-218354784
sure, you don't have to ask for permission to review a patch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13041#issuecomment-218351064
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13041#issuecomment-218351065
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13041#issuecomment-218350952
**[Test build #58308 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58308/consoleFull)**
for PR 13041 at commit
[`17b3c58`](https://g
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/13041#issuecomment-218349299
Related with https://github.com/apache/spark/pull/12904 and
https://github.com/apache/spark/pull/12921.
@andrewor14 Do you mind if I review this?
---
If y
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13041#issuecomment-218348780
**[Test build #58315 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58315/consoleFull)**
for PR 13041 at commit
[`85d0843`](https://gi
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/13041#issuecomment-218345563
(I think it would be nicer if the PR description is fill up.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13041#issuecomment-218341906
**[Test build #58308 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58308/consoleFull)**
for PR 13041 at commit
[`17b3c58`](https://gi
Github user anabranch commented on the pull request:
https://github.com/apache/spark/pull/13041#issuecomment-218341617
cc: @andrewor14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
20 matches
Mail list logo
