[GitHub] spark pull request: [SPARK-15280] [Input/Output] Refactored OrcOut...

2016-05-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13066 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-15280] [Input/Output] Refactored OrcOut...

2016-05-21 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/13066#issuecomment-220805144 Merging to master and branch 2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-15280] [Input/Output] Refactored OrcOut...

2016-05-21 Thread seyfe
Github user seyfe commented on the pull request: https://github.com/apache/spark/pull/13066#issuecomment-220795406 Thanks @yhuai. I updated the description accordingly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-15280] [Input/Output] Refactored OrcOut...

2016-05-21 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/13066#issuecomment-220795260 LGTM. I will merge this to master and branch 2.0 once the description is updated. Also regarding "How was this patch tested?", we can say that manual tests and existing

[GitHub] spark pull request: [SPARK-15280] [Input/Output] Refactored OrcOut...

2016-05-21 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/13066#issuecomment-220795180 @seyfe Can you also update the description (since we are doing a refactoring instead of adding a new public class)? --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-15280] [Input/Output] Refactored OrcOut...

2016-05-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13066#issuecomment-220753806 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15280] [Input/Output] Refactored OrcOut...

2016-05-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13066#issuecomment-220753805 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15280] [Input/Output] Refactored OrcOut...

2016-05-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13066#issuecomment-220753768 **[Test build #59052 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59052/consoleFull)** for PR 13066 at commit

[GitHub] spark pull request: [SPARK-15280] [Input/Output] Refactored OrcOut...

2016-05-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13066#issuecomment-220751101 **[Test build #59052 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59052/consoleFull)** for PR 13066 at commit

[GitHub] spark pull request: [SPARK-15280] [Input/Output] Refactored OrcOut...

2016-05-20 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/13066#issuecomment-220750857 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-15280] [Input/Output] Refactored OrcOut...

2016-05-20 Thread seyfe
Github user seyfe commented on a diff in the pull request: https://github.com/apache/spark/pull/13066#discussion_r64117831 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcRelation.scala --- @@ -167,39 +166,69 @@ private[sql] class DefaultSource } }

[GitHub] spark pull request: [SPARK-15280] [Input/Output] Refactored OrcOut...

2016-05-20 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/13066#discussion_r64079348 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcRelation.scala --- @@ -167,39 +166,69 @@ private[sql] class DefaultSource } }

[GitHub] spark pull request: [SPARK-15280] [Input/Output] Refactored OrcOut...

2016-05-16 Thread seyfe
Github user seyfe commented on the pull request: https://github.com/apache/spark/pull/13066#issuecomment-219581242 Hi @liancheng and @yhuai, Would you mind looking at this pull request? I would appreciate that. Thanks, Ergin --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-15280] [Input/Output] Refactored OrcOut...

2016-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13066#issuecomment-218615472 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15280] [Input/Output] Refactored OrcOut...

2016-05-11 Thread seyfe
GitHub user seyfe opened a pull request: https://github.com/apache/spark/pull/13066 [SPARK-15280] [Input/Output] Refactored OrcOutputWriter and moved serialization to a new class. ## What changes were proposed in this pull request? Move ORC serialization logic from