[GitHub] spark pull request: [SPARK-15282][SQL][DOCS] Add notes of the dete...

2016-05-23 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/13087#issuecomment-221095790 merging to master and 2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-15282][SQL][DOCS] Add notes of the dete...

2016-05-23 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/13087#issuecomment-221095595 sure thats fine. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark pull request: [SPARK-15282][SQL][DOCS] Add notes of the dete...

2016-05-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/13087#issuecomment-221093278 Hi, @marmbrus . Instead of creating new JIRA, I think we had better change the title of this PR into `[MINOR][SQL][DOC] ...`. Initially, I tried to handle

[GitHub] spark pull request: [SPARK-15282][SQL][DOCS] Add notes of the dete...

2016-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13087#issuecomment-221073959 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15282][SQL][DOCS] Add notes of the dete...

2016-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13087#issuecomment-221073961 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15282][SQL][DOCS] Add notes of the dete...

2016-05-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13087#issuecomment-221073588 **[Test build #59147 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59147/consoleFull)** for PR 13087 at commit [`c1f92c7`](https://g

[GitHub] spark pull request: [SPARK-15282][SQL][DOCS] Add notes of the dete...

2016-05-23 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/13087#issuecomment-221064956 LGTM pending tests. @linbojin, we should also handle your use case though maybe that should be its own JIRA. Perhaps you could open one with the information y

[GitHub] spark pull request: [SPARK-15282][SQL][DOCS] Add notes of the dete...

2016-05-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/13087#issuecomment-221049934 Hi, @marmbrus . I replaced 'should' with 'must', and added the detail description for `functions.py`, `SQLContext.scala`, `SparkSession.scala` and `UserDefin

[GitHub] spark pull request: [SPARK-15282][SQL][DOCS] Add notes of the dete...

2016-05-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13087#issuecomment-221049218 **[Test build #59147 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59147/consoleFull)** for PR 13087 at commit [`c1f92c7`](https://gi

[GitHub] spark pull request: [SPARK-15282][SQL][DOCS] Add notes of the dete...

2016-05-23 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/13087#discussion_r64259325 --- Diff: python/pyspark/sql/functions.py --- @@ -1756,6 +1756,7 @@ def __call__(self, *cols): @since(1.3) def udf(f, returnType=StringType())

[GitHub] spark pull request: [SPARK-15282][SQL][DOCS] Add notes of the dete...

2016-05-23 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/13087#discussion_r64256143 --- Diff: python/pyspark/sql/functions.py --- @@ -1756,6 +1756,7 @@ def __call__(self, *cols): @since(1.3) def udf(f, returnType=StringType()):

[GitHub] spark pull request: [SPARK-15282][SQL][DOCS] Add notes of the dete...

2016-05-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13087#issuecomment-220860884 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15282][SQL][DOCS] Add notes of the dete...

2016-05-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13087#issuecomment-220860885 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15282][SQL][DOCS] Add notes of the dete...

2016-05-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13087#issuecomment-220860842 **[Test build #59113 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59113/consoleFull)** for PR 13087 at commit [`7c11e2e`](https://g

[GitHub] spark pull request: [SPARK-15282][SQL][DOCS] Add notes of the dete...

2016-05-22 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/13087#issuecomment-220858268 Thank you, @felixcheung ! Then, this PR is enough for the current master branch. :) If SparkR have something related to this in the future, we can add a note

[GitHub] spark pull request: [SPARK-15282][SQL][DOCS] Add notes of the dete...

2016-05-22 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/13087#issuecomment-220858022 @dongjoon-hyun I don't think we support UDF this way in SparkR? Maybe something we could add to `dapply`? @sun-rui --- If your project is set up for it, you ca

[GitHub] spark pull request: [SPARK-15282][SQL][DOCS] Add notes of the dete...

2016-05-22 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/13087#issuecomment-220857498 I added for Scaladoc/Javadoc/Pydoc, but I cannot find proper places exposed in SparkR doc. Hi, @shivaram , @davies , @felixcheung . Should we need to

[GitHub] spark pull request: [SPARK-15282][SQL][DOCS] Add notes of the dete...

2016-05-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13087#issuecomment-220857000 **[Test build #59113 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59113/consoleFull)** for PR 13087 at commit [`7c11e2e`](https://gi