[GitHub] spark pull request: [SPARK-15318][ML][Example]:spark.ml Collaborat...

2016-05-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13110 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-15318][ML][Example]:spark.ml Collaborat...

2016-05-17 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/13110#issuecomment-219762504 Merged to master/2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-15318][ML][Example]:spark.ml Collaborat...

2016-05-17 Thread yanboliang
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/13110#issuecomment-219754259 @wangmiao1981 @srowen Got it. Thanks for kindly remind! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-15318][ML][Example]:spark.ml Collaborat...

2016-05-17 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/13110#issuecomment-219659650 The Rating _case class_ was not removed, just the _object_. The Java example has no equivalent and is OK as-is. --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-15318][ML][Example]:spark.ml Collaborat...

2016-05-16 Thread wangmiao1981
Github user wangmiao1981 commented on the pull request: https://github.com/apache/spark/pull/13110#issuecomment-219484431 @yanboliang For JAVA example, class Rating is equivalent to case class Rating in scala example. It is not straightforward to remove class Rating in JAVA. I remove

[GitHub] spark pull request: [SPARK-15318][ML][Example]:spark.ml Collaborat...

2016-05-16 Thread yanboliang
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/13110#issuecomment-219462905 @wangmiao1981 Since you removed ```Rating``` for Scala example, I think it's better to do same thing for Java/Python example, and we should make them consistent.

[GitHub] spark pull request: [SPARK-15318][ML][Example]:spark.ml Collaborat...

2016-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13110#issuecomment-219313319 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15318][ML][Example]:spark.ml Collaborat...

2016-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13110#issuecomment-219313318 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15318][ML][Example]:spark.ml Collaborat...

2016-05-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13110#issuecomment-219313297 **[Test build #58619 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58619/consoleFull)** for PR 13110 at commit

[GitHub] spark pull request: [SPARK-15318][ML][Example]:spark.ml Collaborat...

2016-05-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13110#issuecomment-219312924 **[Test build #58619 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58619/consoleFull)** for PR 13110 at commit

[GitHub] spark pull request: [SPARK-15318][ML][Example]:spark.ml Collaborat...

2016-05-14 Thread wangmiao1981
Github user wangmiao1981 commented on a diff in the pull request: https://github.com/apache/spark/pull/13110#discussion_r63284035 --- Diff: examples/src/main/scala/org/apache/spark/examples/ml/ALSExample.scala --- @@ -28,7 +28,7 @@ object ALSExample { // $example on$

[GitHub] spark pull request: [SPARK-15318][ML][Example]:spark.ml Collaborat...

2016-05-14 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/13110#discussion_r63273137 --- Diff: examples/src/main/scala/org/apache/spark/examples/ml/ALSExample.scala --- @@ -28,7 +28,7 @@ object ALSExample { // $example on$

[GitHub] spark pull request: [SPARK-15318][ML][Example]:spark.ml Collaborat...

2016-05-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13110#issuecomment-219183105 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15318][ML][Example]:spark.ml Collaborat...

2016-05-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13110#issuecomment-219183104 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15318][ML][Example]:spark.ml Collaborat...

2016-05-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13110#issuecomment-219183057 **[Test build #58597 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58597/consoleFull)** for PR 13110 at commit

[GitHub] spark pull request: [SPARK-15318][ML][Example]:spark.ml Collaborat...

2016-05-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13110#issuecomment-219182172 **[Test build #58597 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58597/consoleFull)** for PR 13110 at commit

[GitHub] spark pull request: [SPARK-15318][ML][Example]:spark.ml Collaborat...

2016-05-13 Thread wangmiao1981
GitHub user wangmiao1981 opened a pull request: https://github.com/apache/spark/pull/13110 [SPARK-15318][ML][Example]:spark.ml Collaborative Filtering example does not work in spark-shell ## What changes were proposed in this pull request? (Please fill in changes proposed