[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...

2016-05-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219332692 **[Test build #58623 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58623/consoleFull)** for PR 13112 at commit [`ff0b7fd`](https://gi

[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...

2016-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219296347 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...

2016-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219296346 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...

2016-05-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219296305 **[Test build #58613 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58613/consoleFull)** for PR 13112 at commit [`fbea7a3`](https://g

[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...

2016-05-15 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219292014 Those do look like instances that can be changed, yes. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...

2016-05-15 Thread WeichenXu123
Github user WeichenXu123 commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219291622 @srowen I use Intellj-IDEA to search usage of deprecate SparkContext.accumulator in the whole spark project, and update the code.(except those test code for accu

[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...

2016-05-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219291395 **[Test build #58613 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58613/consoleFull)** for PR 13112 at commit [`fbea7a3`](https://gi

[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...

2016-05-14 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219208034 Rather than change this in just a couple places, can you update all internal usages of the old accumulator API? --- If your project is set up for it, you can reply to t

[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...

2016-05-14 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13112#discussion_r63272945 --- Diff: mllib/src/main/scala/org/apache/spark/ml/util/stopwatches.scala --- @@ -19,7 +19,8 @@ package org.apache.spark.ml.util import scala.

[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...

2016-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219207501 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...

2016-05-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219207485 **[Test build #58603 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58603/consoleFull)** for PR 13112 at commit [`2761dff`](https://g

[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...

2016-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219207500 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...

2016-05-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219206065 **[Test build #58603 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58603/consoleFull)** for PR 13112 at commit [`2761dff`](https://gi

[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...

2016-05-14 Thread MLnick
Github user MLnick commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219206010 Jenkins add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...

2016-05-13 Thread yanboliang
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219204283 This looks good. ping @mengxr @jkbradley @MLnick Could you help to add @WeichenXu123 to whitelist? Thanks. --- If your project is set up for it, you can reply to th

[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...

2016-05-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13112#issuecomment-219204019 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: [SPARK-15322][mllib]update deprecate accumulat...

2016-05-13 Thread WeichenXu123
GitHub user WeichenXu123 opened a pull request: https://github.com/apache/spark/pull/13112 [SPARK-15322][mllib]update deprecate accumulator usage into accumulatorV2 in mllib ## What changes were proposed in this pull request? MLlib code has two position use sc.accumulator m