[GitHub] spark pull request: [SPARK-15491][SQL]fix assertion failure for JD...

2016-05-27 Thread huaxingao
Github user huaxingao commented on the pull request: https://github.com/apache/spark/pull/13287#issuecomment-21356 @rxin Thanks for your comment. When I wrote the test, I found there is one more place I need to change. So there are two places that have problems: 1. TreeN

[GitHub] spark pull request: [SPARK-15491][SQL]fix assertion failure for JD...

2016-05-25 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13287#issuecomment-221739911 Can we create a unit test for TreeNode, rather than using JDBC? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-15491][SQL]fix assertion failure for JD...

2016-05-25 Thread huaxingao
Github user huaxingao commented on the pull request: https://github.com/apache/spark/pull/13287#issuecomment-221617823 @rxin Sorry, I didn't notice your comment until this morning. Reformatted the description. Thanks! --- If your project is set up for it, you can reply to this emai

[GitHub] spark pull request: [SPARK-15491][SQL]fix assertion failure for JD...

2016-05-24 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13287#issuecomment-221476178 Thanks for the pull request. Can you format the description better? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-15491][SQL]fix assertion failure for JD...

2016-05-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13287#issuecomment-221441031 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: [SPARK-15491][SQL]fix assertion failure for JD...

2016-05-24 Thread huaxingao
GitHub user huaxingao opened a pull request: https://github.com/apache/spark/pull/13287 [SPARK-15491][SQL]fix assertion failure for JDBC DataFrame to JSON ## What changes were proposed in this pull request? in TreeNode.scala parseToJson, it has case p: Product => try {