[GitHub] spark pull request: [SPARK-15528][SQL] Fix race condition in Numbe...

2016-05-30 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13391#issuecomment-222539400 Yes this is definitely a problem worth fixing. We should probably also backport this into 1.6. cc @davies @sameeragarwal --- If your project is set up for it, y

[GitHub] spark pull request: [SPARK-15528][SQL] Fix race condition in Numbe...

2016-05-30 Thread maropu
Github user maropu commented on the pull request: https://github.com/apache/spark/pull/13391#issuecomment-222465573 @rxin @tarekauel Seems this bug is a kind of critical issues, so we need to fix for the v2.0 release, thought? --- If your project is set up for it, you can reply to th

[GitHub] spark pull request: [SPARK-15528][SQL] Fix race condition in Numbe...

2016-05-29 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/13391#issuecomment-222357345 CC @tarekauel It is certainly a problem if this code is called from several threads in one JVM. It's possible it was written this way because for whatever reason this wi

[GitHub] spark pull request: [SPARK-15528][SQL] Fix race condition in Numbe...

2016-05-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13391#issuecomment-222348891 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15528][SQL] Fix race condition in Numbe...

2016-05-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13391#issuecomment-222348890 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15528][SQL] Fix race condition in Numbe...

2016-05-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13391#issuecomment-222348854 **[Test build #59584 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59584/consoleFull)** for PR 13391 at commit [`374d679`](https://g

[GitHub] spark pull request: [SPARK-15528][SQL] Fix race condition in Numbe...

2016-05-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13391#issuecomment-222346173 **[Test build #59584 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59584/consoleFull)** for PR 13391 at commit [`374d679`](https://gi

[GitHub] spark pull request: [SPARK-15528][SQL] Fix race condition in Numbe...

2016-05-28 Thread maropu
GitHub user maropu opened a pull request: https://github.com/apache/spark/pull/13391 [SPARK-15528][SQL] Fix race condition in NumberConverter ## What changes were proposed in this pull request? A local variable in NumberConverter is wrongly shared between threads. This pr fix