Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/13315#issuecomment-222042460
Thanks for all the LGTMs. I'm going to merge this into master 2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13315#issuecomment-222039997
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13315#issuecomment-22204
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13315#issuecomment-222039878
**[Test build #59434 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59434/consoleFull)**
for PR 13315 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13315#issuecomment-222029803
**[Test build #59434 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59434/consoleFull)**
for PR 13315 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13315#issuecomment-222011825
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13315#issuecomment-222011824
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13315#issuecomment-222011653
**[Test build #59417 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59417/consoleFull)**
for PR 13315 at commit
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/13315#issuecomment-221998770
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user sureshthalamati commented on the pull request:
https://github.com/apache/spark/pull/13315#issuecomment-221998114
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/13315#issuecomment-221997409
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/13315#issuecomment-221994189
I tested partitioned data source tables too. If you add data back then the
partitions will be created again. I think that's OK.
---
If your project is set up for
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13315#issuecomment-221991110
**[Test build #59417 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59417/consoleFull)**
for PR 13315 at commit
Github user sureshthalamati commented on the pull request:
https://github.com/apache/spark/pull/13315#issuecomment-221990818
@andrewor14 one minor thing I noticed when I looked at the table data
directories; In the case of regular tables truncate keeps the partition
directories,
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13315#issuecomment-221984931
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13315#issuecomment-221984936
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13315#issuecomment-221984586
**[Test build #59401 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59401/consoleFull)**
for PR 13315 at commit
Github user sureshthalamati commented on the pull request:
https://github.com/apache/spark/pull/13315#issuecomment-221980355
@andrewor14 After I cleaned up the old metastore_db , truncate worked as
expected. Thanks
---
If your project is set up for it, you can reply to this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13315#issuecomment-221963878
**[Test build #59401 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59401/consoleFull)**
for PR 13315 at commit
Github user sureshthalamati commented on the pull request:
https://github.com/apache/spark/pull/13315#issuecomment-221953361
@andrewor14 The behavior you mentioned is the one I was expecting also.
For some reason it does not work in my env. I was trying for a spark-shell .
What
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13315#discussion_r64794004
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -289,37 +289,53 @@ case class TruncateTableCommand(
val
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13315#discussion_r64793761
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -289,37 +289,53 @@ case class TruncateTableCommand(
val
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/13315#issuecomment-221949749
{{sql("truncate table emp16") }} should delete all partitions, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/13315#issuecomment-221949078
@sureshthalamati what behavior did you expect? I would think that
truncating a partitioned table without specifying the specs should just delete
data from all
Github user lianhuiwang commented on the pull request:
https://github.com/apache/spark/pull/13315#issuecomment-221902799
@andrewor14 I think catalog.invalidateTable(tableName) can fix
@sureshthalamati 's problem.
---
If your project is set up for it, you can reply to this email and
Github user sureshthalamati commented on the pull request:
https://github.com/apache/spark/pull/13315#issuecomment-221768017
@andrewor14
I tried this PR. It does not seem to work/raise error if user attempts
to truncate on partition table with out specifying the partition
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13315#issuecomment-221760298
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13315#issuecomment-221760297
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13315#issuecomment-221760153
**[Test build #59323 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59323/consoleFull)**
for PR 13315 at commit
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/13315#issuecomment-221751879
@hvanhovell @yhuai
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13315#issuecomment-221750404
**[Test build #59323 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59323/consoleFull)**
for PR 13315 at commit
31 matches
Mail list logo
