[GitHub] spark pull request: [SPARK-1825] Fixes cross-platform submit probl...

2015-02-08 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/899#issuecomment-73424410 I didn't fix it, @tsudukim did, so thank him :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-1825] Fixes cross-platform submit probl...

2015-02-08 Thread zeodtr
Github user zeodtr closed the pull request at: https://github.com/apache/spark/pull/899 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] spark pull request: [SPARK-1825] Fixes cross-platform submit probl...

2015-02-08 Thread zeodtr
Github user zeodtr commented on the pull request: https://github.com/apache/spark/pull/899#issuecomment-73406987 @andrewor14 Ok, Thanks for fixing! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-1825] Fixes cross-platform submit probl...

2015-02-06 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/899#issuecomment-73301694 Hey @zeodtr I believe this is fixed in #3924 would you mind closing this PR? --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] spark pull request: [SPARK-1825] Fixes cross-platform submit probl...

2014-09-09 Thread zeodtr
Github user zeodtr commented on a diff in the pull request: https://github.com/apache/spark/pull/899#discussion_r17338037 --- Diff: yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala --- @@ -309,7 +310,7 @@ trait ClientBase extends Logging { // Add Xm

[GitHub] spark pull request: [SPARK-1825] Fixes cross-platform submit probl...

2014-09-06 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/899#issuecomment-54723174 No worries. We can build on top of your patch to make this work for hadoop versions < 2.4. Thanks for digging through this code. --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-1825] Fixes cross-platform submit probl...

2014-09-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/899#issuecomment-54700786 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19884/consoleFull) for PR 899 at commit [`b768fc6`](https://github.com/apa

[GitHub] spark pull request: [SPARK-1825] Fixes cross-platform submit probl...

2014-09-05 Thread zeodtr
Github user zeodtr commented on the pull request: https://github.com/apache/spark/pull/899#issuecomment-54700088 @andrewor14 @vanzin As I already mentioned in another comment, This won't compile on Hadoop < 2.4. So I suggested another method, but currently I have not enough knowledge

[GitHub] spark pull request: [SPARK-1825] Fixes cross-platform submit probl...

2014-09-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/899#issuecomment-54698949 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19884/consoleFull) for PR 899 at commit [`b768fc6`](https://github.com/apac

[GitHub] spark pull request: [SPARK-1825] Fixes cross-platform submit probl...

2014-09-05 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/899#issuecomment-54697571 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] spark pull request: [SPARK-1825] Fixes cross-platform submit probl...

2014-09-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/899#issuecomment-54694693 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] spark pull request: [SPARK-1825] Fixes cross-platform submit probl...

2014-09-05 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/899#issuecomment-54676894 Also, I notice that this is opened against branch-1.0. It would be better if you could open it against the master branch so the latest Spark releases will also benefit

[GitHub] spark pull request: [SPARK-1825] Fixes cross-platform submit probl...

2014-09-05 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/899#issuecomment-54676819 @zeodtr Thanks for updating the title. Just so I understand the issue, for HDP 2.1 on Windows we need these changes for Spark to run, is that correct? However, with thi

[GitHub] spark pull request: [SPARK-1825] Fixes cross-platform submit probl...

2014-09-05 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/899#discussion_r17195370 --- Diff: yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala --- @@ -309,7 +310,7 @@ trait ClientBase extends Logging { // Ad

[GitHub] spark pull request: [SPARK-1825] Fixes cross-platform submit probl...

2014-09-05 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/899#issuecomment-54652280 @zeodtr does this compile with anything < hadoop 2.4? If it doesn't, this is a no-go. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-1825] Fixes cross-platform submit probl...

2014-09-04 Thread zeodtr
Github user zeodtr commented on the pull request: https://github.com/apache/spark/pull/899#issuecomment-54565600 @andrewor14 Updated the title. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have