[GitHub] spark pull request: [SPARK-1978] In some cases, spark-yarn does no...

2014-06-10 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/921#issuecomment-45630504 Looks good, +1. Thanks @witgo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-1978] In some cases, spark-yarn does no...

2014-06-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/921 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-1978] In some cases, spark-yarn does no...

2014-06-10 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/921#issuecomment-45654604 I merged this into branch-1.0 also --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-1978] In some cases, spark-yarn does no...

2014-06-09 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/921#issuecomment-45565232 Done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request: [SPARK-1978] In some cases, spark-yarn does no...

2014-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/921#issuecomment-45565212 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-1978] In some cases, spark-yarn does no...

2014-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/921#issuecomment-45572939 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-1978] In some cases, spark-yarn does no...

2014-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/921#issuecomment-45574678 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-1978] In some cases, spark-yarn does no...

2014-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/921#issuecomment-45574679 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15593/ --- If your project

[GitHub] spark pull request: [SPARK-1978] In some cases, spark-yarn does no...

2014-06-09 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/921#discussion_r13544073 --- Diff: yarn/stable/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -252,16 +252,12 @@ class ApplicationMaster(args:

[GitHub] spark pull request: [SPARK-1978] In some cases, spark-yarn does no...

2014-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/921#issuecomment-45502955 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-1978] In some cases, spark-yarn does no...

2014-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/921#issuecomment-45502967 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-1978] In some cases, spark-yarn does no...

2014-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/921#issuecomment-45508152 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-1978] In some cases, spark-yarn does no...

2014-06-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/921#issuecomment-45508153 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15568/ --- If your project

[GitHub] spark pull request: [SPARK-1978] In some cases, spark-yarn does no...

2014-06-09 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/921#discussion_r13557054 --- Diff: yarn/stable/src/main/scala/org/apache/spark/deploy/yarn/ExecutorLauncher.scala --- @@ -200,17 +200,24 @@ class ExecutorLauncher(args:

[GitHub] spark pull request: [SPARK-1978] In some cases, spark-yarn does no...

2014-06-09 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/921#issuecomment-45527574 Thanks @witgo if you can change the order of the logic in the ExecutorLauncher to match, this looks good. --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-1978] In some cases, spark-yarn does no...

2014-06-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/921#issuecomment-45457563 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-1978] In some cases, spark-yarn does no...

2014-06-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/921#issuecomment-45457570 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-1978] In some cases, spark-yarn does no...

2014-06-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/921#issuecomment-45458838 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-1978] In some cases, spark-yarn does no...

2014-06-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/921#issuecomment-45458840 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15551/ --- If your project

[GitHub] spark pull request: [SPARK-1978] In some cases, spark-yarn does no...

2014-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/921#issuecomment-45199214 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-1978] In some cases, spark-yarn does no...

2014-06-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/921#issuecomment-45202086 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-1978] In some cases, spark-yarn does no...

2014-06-05 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/921#discussion_r13454932 --- Diff: yarn/stable/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -252,16 +252,12 @@ class ApplicationMaster(args:

[GitHub] spark pull request: [SPARK-1978] In some cases, spark-yarn does no...

2014-06-05 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/921#discussion_r13454917 --- Diff: yarn/stable/src/main/scala/org/apache/spark/deploy/yarn/ExecutorLauncher.scala --- @@ -200,17 +200,24 @@ class ExecutorLauncher(args:

[GitHub] spark pull request: [SPARK-1978] In some cases, spark-yarn does no...

2014-06-05 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/921#discussion_r13457794 --- Diff: yarn/stable/src/main/scala/org/apache/spark/deploy/yarn/ExecutorLauncher.scala --- @@ -204,9 +204,17 @@ class ExecutorLauncher(args:

[GitHub] spark pull request: [SPARK-1978] In some cases, spark-yarn does no...

2014-06-05 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/921#discussion_r13474143 --- Diff: yarn/stable/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -252,16 +252,12 @@ class ApplicationMaster(args:

[GitHub] spark pull request: [SPARK-1978] In some cases, spark-yarn does no...

2014-06-04 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/921#discussion_r13395249 --- Diff: yarn/stable/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -256,14 +256,22 @@ class ApplicationMaster(args:

[GitHub] spark pull request: [SPARK-1978] In some cases, spark-yarn does no...

2014-06-04 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/921#discussion_r13395681 --- Diff: yarn/stable/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -256,14 +256,22 @@ class ApplicationMaster(args:

[GitHub] spark pull request: [SPARK-1978] In some cases, spark-yarn does no...

2014-06-04 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/921#discussion_r13395786 --- Diff: yarn/stable/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -256,14 +256,22 @@ class ApplicationMaster(args:

[GitHub] spark pull request: [SPARK-1978] In some cases, spark-yarn does no...

2014-06-04 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/921#discussion_r13396177 --- Diff: yarn/stable/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -256,14 +256,22 @@ class ApplicationMaster(args:

[GitHub] spark pull request: [SPARK-1978] In some cases, spark-yarn does no...

2014-06-04 Thread witgo
Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/921#discussion_r13425322 --- Diff: yarn/stable/src/main/scala/org/apache/spark/deploy/yarn/ExecutorLauncher.scala --- @@ -204,9 +204,17 @@ class ExecutorLauncher(args: