Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50854138
@witgo Could you update the pom to exclude `commons-math3` from
dependencies? I tried at local and LBFGS works well. It should be safe to
remove `commons-math3`. For
Github user witgo commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50855187
@mengxr done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/940#discussion_r15684374
--- Diff: mllib/pom.xml ---
@@ -60,6 +60,14 @@
groupIdjunit/groupId
artifactIdjunit/artifactId
/exclusion
+
Github user witgo commented on a diff in the pull request:
https://github.com/apache/spark/pull/940#discussion_r15684437
--- Diff: mllib/pom.xml ---
@@ -60,6 +60,14 @@
groupIdjunit/groupId
artifactIdjunit/artifactId
/exclusion
+
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50859290
QA results for PR 940:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user witgo commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50860276
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50860395
QA tests have started for PR 940. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17666/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50864392
QA results for PR 940:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50892988
LGTM. Merged into master. Note that Jenkins didn't tell the full story
because we have `commons-math3` in the test scope. I built the assembly jar and
verified LBFGS work.
Github user avati commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50894442
@mengxr Based on the dependency graph, I am guessing we will now have jar
hell problem with scalalogging-slf4j 2.1.2 (needed by breeze 0.8.1) vs 1.0.1
(used by sql/).
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50896659
Is that a problem? just update `sql/catalyst` to use 2.1.2? Do we know if
that would be any problem? @witgo has a PR to standardize use of
scalalogging-slf4j anyway
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50896710
Ah, I see. Tests were against individual build instead of the assembly jar.
We should have integration tests in the future.
---
If your project is set up for it, you can
Github user avati commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50897230
Yes, either #1701 or #1369. We are already broken till they are committed.
On Fri, Aug 1, 2014 at 8:19 AM, Xiangrui Meng notificati...@github.com
wrote:
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/940
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user avati commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50899294
I think Jenkins should be fine but the assembly jar is broken. Is it
right?
I think so, just like commons-math3
---
If your project is set up for it, you
Github user witgo commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50906124
How do we resolve this issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50908990
I reverted the change in #1718 and asked @marmbrus to take look at the
dependency issues caused by scala-logging.
---
If your project is set up for it, you can reply to
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50909587
I think @witgo's PR strongly suggests it's OK to upgrade to 2.1.2?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user avati commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50910905
I reverted the change in #1718 https://github.com/apache/spark/pull/1718
and asked @marmbrus https://github.com/marmbrus to take look at the
dependency issues
Github user avati commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50849972
@mengxr looking at the dependency graphs of breeze 0.7 and 0.8.1, it
appears that both the versions are depending on commons-math3:3.2. If hadoop
2.3 and 2.4 depend on
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50850308
Yes, it is already a problem with breeze 0.7. But we didn't realized that
hadoop 2.3 depends on commons-math3 in the Spark v1.0 release. If there is a
way to avoid
Github user avati commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50850441
Yes, it is already a problem with breeze 0.7. But we didn't realized that
hadoop 2.3 depends on commons-math3 in the Spark v1.0 release. If there is
a way to avoid
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50850626
But is it needed for the v1.1 release? Spark v1.1 doesn't support Scala
2.11.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user avati commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50850842
But is it needed for the v1.1 release? Spark v1.1 doesn't support Scala
2.11.
Not, I guess. I din't realize Spark 1.1 was not yet release branched. I
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50851243
That sounds good to me but I'm not familiar with the tasks related to Scala
2.11. Please run the discussion on
https://issues.apache.org/jira/browse/SPARK-1812
---
If
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50303013
@witgo Thanks for checking the dependencies on the JIRA page! I list the
dependency graph here so other people can see the difference easily. I think we
need to figure out
Github user dlwh commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50310077
Release Plans implies that there is a plan. :-). My general policy is to
cut a release whenever someone asks (or within a couple of weeks of that).
We've done a bunch of
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50369429
David is right that quasiquotes are just a compile time dependency and are
not needed at runtime. Also, we will be pulling them in for codegen in Spark
SQL, so there is
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50379548
@dlwh Thanks for the quick reply! The `commons-math3` problem is not which
version to use but how to match the version hadoop depends on. We can switch to
3.1.1 to match
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50291749
QA tests have started for PR 940. This patch DID NOT merge cleanly!
brView progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17265/consoleFull
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50291855
@witgo Could you merge the latest master? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user witgo commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50293501
@mengxr Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50293521
QA tests have started for PR 940. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17268/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50295014
QA results for PR 940:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user witgo commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50297230
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50297424
QA tests have started for PR 940. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17271/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-50299031
QA results for PR 940:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-49578863
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-49508061
QA tests have started for PR 940. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16848/consoleFull
---
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-46529144
@nevillelyh Is there a JIRA for it? Is it fixed in 0.8.1?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user nevillelyh commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-46575215
@mengxr https://issues.apache.org/jira/browse/SPARK-2200
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user nevillelyh commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-46521234
We just hit a bug when DenseVector in 0.7 triggers StackOverflowError in
KryoSerializer.
---
If your project is set up for it, you can reply to this email and have
Github user witgo commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-44911857
@markhamstra , `breeze 0.7 ` does not support `scala 2.11` .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user markhamstra commented on the pull request:
https://github.com/apache/spark/pull/940#issuecomment-44914945
Neither does spark 1.0.0.
We've offered no guarantee that any spark 1.x will work with scala 2.11.
If it turns out that we can't cross-compile for scala 2.10
44 matches
Mail list logo
