Github user baishuo commented on the pull request:
https://github.com/apache/spark/pull/3740#issuecomment-68230642
I learn a lot when review this PRï¼thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/3740#issuecomment-67807114
Thanks - I will merge the new PR once tests pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/3740#issuecomment-67805801
See #3758
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/3740#issuecomment-67805360
`RDD.rddToPairRDDFunctions` needs to be changed to `rddToPairRDDFunctions`
for branch-1.2
---
If your project is set up for it, you can reply to this email and have you
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/3740#issuecomment-67805327
Need to backport this one to branch-1.2, as the implicit APIs fixes do not
exist in branch-1.2
---
If your project is set up for it, you can reply to this email and have
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3740
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/3740#issuecomment-67805239
Thanks - merging in master & branch-1.2.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3740#issuecomment-67739261
[Test build #24670 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24670/consoleFull)
for PR 3740 at commit
[`39d9df2`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3740#issuecomment-67739263
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3740#discussion_r22141877
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -1174,7 +1174,19 @@ abstract class RDD[T: ClassTag](
* Save this RDD as a text file
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3740#discussion_r22141873
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -1182,7 +1194,14 @@ abstract class RDD[T: ClassTag](
* Save this RDD as a compresse
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3740#issuecomment-67736916
[Test build #24670 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24670/consoleFull)
for PR 3740 at commit
[`39d9df2`](https://githu
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3740#discussion_r22127907
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -1174,7 +1174,19 @@ abstract class RDD[T: ClassTag](
* Save this RDD as a text file, u
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3740#discussion_r22127836
--- Diff:
core/src/main/scala/org/apache/spark/input/FixedLengthBinaryInputFormat.scala
---
@@ -33,7 +34,8 @@ private[spark] object FixedLengthBinaryInputFormat
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3740#discussion_r22127807
--- Diff:
core/src/main/scala/org/apache/spark/input/PortableDataStream.scala ---
@@ -19,6 +19,8 @@ package org.apache.spark.input
import java.io.{Byt
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3740#discussion_r22127764
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -1174,7 +1174,19 @@ abstract class RDD[T: ClassTag](
* Save this RDD as a text file, u
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3740#discussion_r22127758
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -1182,7 +1194,14 @@ abstract class RDD[T: ClassTag](
* Save this RDD as a compressed t
Github user aarondav commented on the pull request:
https://github.com/apache/spark/pull/3740#issuecomment-67680383
@rxin I'm not a core maintainer, and also at this point it's mainly an
issue of how to style this so it is clear to future readers, so could you take
a look?
---
If yo
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3740#issuecomment-67615116
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3740#issuecomment-67615113
[Test build #24635 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24635/consoleFull)
for PR 3740 at commit
[`734bac9`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3740#issuecomment-67608353
[Test build #24635 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24635/consoleFull)
for PR 3740 at commit
[`734bac9`](https://githu
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3740#discussion_r22093377
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -1174,6 +1174,14 @@ abstract class RDD[T: ClassTag](
* Save this RDD as a text file
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/3740#discussion_r22092697
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -1174,6 +1174,14 @@ abstract class RDD[T: ClassTag](
* Save this RDD as a text fil
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3740#issuecomment-67602317
[Test build #24624 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24624/consoleFull)
for PR 3740 at commit
[`ca03559`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3740#issuecomment-67602319
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3740#issuecomment-67597016
[Test build #24624 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24624/consoleFull)
for PR 3740 at commit
[`ca03559`](https://githu
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/3740#issuecomment-67596925
Since `WriteInputFormatTestDataGenerator` is for python test, we can ignore
it.
Now for other codes in Spark core, Scala will generate same byte codes for
Hadoop
27 matches
Mail list logo
