Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/2405#issuecomment-66282781
This PR is blocked by https://github.com/apache/spark/pull/2543. I'll
update the code tomorrow and make it work :)
---
If your project is set up for it, you can reply
Github user ayoub-benali commented on the pull request:
https://github.com/apache/spark/pull/2405#issuecomment-66280190
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user sziep commented on the pull request:
https://github.com/apache/spark/pull/2405#issuecomment-66280104
are there any plans on merging this soon? This is a pretty useful feature.
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2405#issuecomment-57695595
that sounds pretty reasonable to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/2405#issuecomment-57647672
I think we can just handle one level nested array to fix SPARK-2096. What
about adding a rule to using another type of `GetField` to handle array of
struct? So that we
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2405#issuecomment-57566803
Okay here are some thoughts and questions:
- I don't think it really matters that we can't handle `f1.f11 > f2.f22`
because we already don't know what do to if a use
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/2405#issuecomment-55987610
@yhuai It's hard to define the semantic of f1.f11 > f2.f22 as they are
arbitrarily nested arrays. What if the array size is not equal? What if the
nested level is not e
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/2405#issuecomment-55980788
What will happen if I use this syntax in predicates?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/2405#issuecomment-55840951
Hmmm, I didn't create the class `NonASCIICharacterChecker`...
This fix also works for hql, but I'm not sure where to put the test case,
any ideas?
---
If your proj
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2405#issuecomment-55810634
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20416/consoleFull)
for PR 2405 at commit
[`b19bbd6`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2405#issuecomment-55797713
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20416/consoleFull)
for PR 2405 at commit
[`b19bbd6`](https://github.com/ap
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2405#issuecomment-55797286
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/2405#discussion_r17583870
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypes.scala
---
@@ -68,36 +72,96 @@ case class GetItem(child: Expres
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/2405#discussion_r17583846
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypes.scala
---
@@ -68,36 +72,96 @@ case class GetItem(child: Expres
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2405#issuecomment-55694178
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/2405
[SPARK-2096][SQL] support dot notation on arbitrarily nested array of struct
The rule is simple: If you want `a.b` work, then `a` must be some level of
nested array of struct(level 0 means just a
16 matches
Mail list logo
