Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-59118853
Hey sorry @witgo there are merge conflicts now. I'll test this again and
merge this once you update it.
---
If your project is set up for it, you can reply to this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-59147101
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21759/consoleFull)
for PR 2379 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-59151254
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-59151248
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21759/consoleFull)
for PR 2379 at commit
Github user witgo commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-59153778
@andrewor14 The code has been updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-59158756
Alright, I'm merging this into master. Thanks @witgo!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2379
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user witgo commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-59159165
Cool! Thanks @andrewor14 @vanzin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-58419872
Thanks, I will look at this shortly. A minor request though: in the future
could you keep around all the commits in your branch? It would help reviewing
if I could
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-58253424
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-58255299
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-58259744
LGTM. Another comments @vanzin?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-58260161
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r18548647
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServerArguments.scala
---
@@ -32,11 +34,16 @@ private[spark] class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-58260972
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21404/consoleFull)
for PR 2379 at commit
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r18548720
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1387,6 +1387,54 @@ private[spark] object Utils extends Logging {
}
}
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-58261206
LGTM, just a couple of minor things.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-58268969
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21404/consoleFull)
for PR 2379 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-58268981
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r18552640
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServerArguments.scala
---
@@ -32,11 +34,16 @@ private[spark] class
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-58270876
Looks like there is a legitimate test failure though, can you resolve this
@witgo?
---
If your project is set up for it, you can reply to this email and have your
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-58271590
I just tested this on the Worker, Master and the HistoryServer and it works
as expected. Awesome.
---
If your project is set up for it, you can reply to this email
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-58299213
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21441/consoleFull)
for PR 2379 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-58304689
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-58304684
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21441/consoleFull)
for PR 2379 at commit
Github user witgo commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-58305582
@andrewor14 The code has been updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-57893391
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21285/consoleFull)
for PR 2379 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-57894238
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-57894236
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21285/consoleFull)
for PR 2379 at commit
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r18100045
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1357,6 +1357,58 @@ private[spark] object Utils extends Logging {
}
Github user witgo commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r18121155
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1357,6 +1357,58 @@ private[spark] object Utils extends Logging {
}
}
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-57039090
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20897/consoleFull)
for PR 2379 at commit
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r18121284
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1357,6 +1357,58 @@ private[spark] object Utils extends Logging {
}
Github user witgo commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r18121404
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1357,6 +1357,58 @@ private[spark] object Utils extends Logging {
}
}
Github user witgo commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-57040105
@andrewor14 The code has been updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-57040212
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20899/consoleFull)
for PR 2379 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-57040598
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-57040597
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20897/consoleFull)
for PR 2379 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-57041561
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-57041560
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20899/consoleFull)
for PR 2379 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-56790524
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user witgo commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-56810769
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-56811320
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20804/consoleFull)
for PR 2379 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-56819375
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20804/consoleFull)
for PR 2379 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-56819381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r18048673
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1357,6 +1357,58 @@ private[spark] object Utils extends Logging {
}
Github user witgo commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r18070980
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1357,6 +1357,58 @@ private[spark] object Utils extends Logging {
}
}
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r18001098
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServerArguments.scala
---
@@ -44,10 +51,17 @@ private[spark] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r18001181
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServerArguments.scala
---
@@ -44,10 +51,17 @@ private[spark] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r18001154
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServerArguments.scala
---
@@ -18,12 +18,14 @@
package
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r18001245
--- Diff:
core/src/main/scala/org/apache/spark/deploy/master/MasterArguments.scala ---
@@ -38,12 +39,14 @@ private[spark] class MasterArguments(args:
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r18001383
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/WorkerArguments.scala ---
@@ -47,15 +48,18 @@ private[spark] class WorkerArguments(args:
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r18001361
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServerArguments.scala
---
@@ -44,10 +51,17 @@ private[spark] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r18001377
--- Diff:
core/src/main/scala/org/apache/spark/deploy/master/MasterArguments.scala ---
@@ -83,7 +90,9 @@ private[spark] class MasterArguments(args:
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r18001538
--- Diff:
core/src/main/scala/org/apache/spark/deploy/master/MasterArguments.scala ---
@@ -38,12 +39,14 @@ private[spark] class MasterArguments(args:
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r18001577
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/WorkerArguments.scala ---
@@ -122,7 +130,9 @@ private[spark] class WorkerArguments(args:
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r18001605
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1357,6 +1357,58 @@ private[spark] object Utils extends Logging {
}
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r18001637
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1357,6 +1357,58 @@ private[spark] object Utils extends Logging {
}
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r18001709
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1357,6 +1357,58 @@ private[spark] object Utils extends Logging {
}
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r18001681
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1357,6 +1357,58 @@ private[spark] object Utils extends Logging {
}
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r18001754
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1357,6 +1357,58 @@ private[spark] object Utils extends Logging {
}
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r18001799
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1357,6 +1357,58 @@ private[spark] object Utils extends Logging {
}
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r18002009
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1357,6 +1357,58 @@ private[spark] object Utils extends Logging {
}
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r18002312
--- Diff: core/src/test/scala/org/apache/spark/util/UtilsSuite.scala ---
@@ -297,4 +300,21 @@ class UtilsSuite extends FunSuite {
}
}
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-56743354
@witgo I made a few more comments on this patch. I believe the semantics
are now correct, but the documentation and style can be improved.
---
If your project is set
Github user witgo commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r18011958
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1357,6 +1357,58 @@ private[spark] object Utils extends Logging {
}
}
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-56207066
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20573/consoleFull)
for PR 2379 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-56207390
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20573/consoleFull)
for PR 2379 at commit
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r17807812
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServerArguments.scala
---
@@ -44,10 +51,18 @@ private[spark] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r17807849
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServerArguments.scala
---
@@ -44,10 +51,18 @@ private[spark] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r17807955
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1357,6 +1357,55 @@ private[spark] object Utils extends Logging {
}
}
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r17808054
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1357,6 +1357,55 @@ private[spark] object Utils extends Logging {
}
}
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r17808036
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1357,6 +1357,55 @@ private[spark] object Utils extends Logging {
}
}
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r17808099
--- Diff: core/src/test/scala/org/apache/spark/util/UtilsSuite.scala ---
@@ -297,4 +300,21 @@ class UtilsSuite extends FunSuite {
}
}
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-56232823
Jenkins complained about some scalastyle issue, can you double check that
you didn't cause it? Otherwise looks good (with a few nits).
---
If your project is set up for
Github user witgo commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-56253206
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-5625
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20604/consoleFull)
for PR 2379 at commit
Github user witgo commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-56253720
Don't know why no trigger Jenkins retest thi,the code should be no problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-56254827
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20604/consoleFull)
for PR 2379 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-56255414
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20605/consoleFull)
for PR 2379 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-56256482
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20605/consoleFull)
for PR 2379 at commit
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r17743007
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServerArguments.scala
---
@@ -44,30 +51,27 @@ private[spark] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r17743439
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/WorkerArguments.scala ---
@@ -47,14 +48,25 @@ private[spark] class WorkerArguments(args:
Github user witgo commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r17744702
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/WorkerArguments.scala ---
@@ -47,14 +48,25 @@ private[spark] class WorkerArguments(args:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r17745188
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/WorkerArguments.scala ---
@@ -47,14 +48,25 @@ private[spark] class WorkerArguments(args:
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r17745821
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/WorkerArguments.scala ---
@@ -47,14 +48,25 @@ private[spark] class WorkerArguments(args:
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r17745881
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServerArguments.scala
---
@@ -44,30 +50,19 @@ private[spark] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r17752106
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServerArguments.scala
---
@@ -44,30 +51,27 @@ private[spark] class
Github user witgo commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r17766151
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServerArguments.scala
---
@@ -44,30 +50,19 @@ private[spark] class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-55916931
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20468/consoleFull)
for PR 2379 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-55926886
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20468/consoleFull)
for PR 2379 at commit
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r17680984
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/WorkerArguments.scala ---
@@ -47,14 +48,15 @@ private[spark] class WorkerArguments(args:
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r17696773
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/WorkerArguments.scala ---
@@ -47,14 +48,15 @@ private[spark] class WorkerArguments(args:
Github user witgo commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-55982531
OK, the code has been updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-55982667
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20507/consoleFull)
for PR 2379 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-55986568
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20507/consoleFull)
for PR 2379 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-55987569
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20519/consoleFull)
for PR 2379 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-55991087
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20519/consoleFull)
for PR 2379 at commit
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/2379#issuecomment-55766467
I think I have an opposite view from Andrew in that I dislike using
sys.props as an IPC mechanism, but other than that, looks good.
---
If your project is set up for it,
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r17610954
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala ---
@@ -167,14 +167,19 @@ class HistoryServer(
* This launches the
1 - 100 of 131 matches
Mail list logo
