Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1210#issuecomment-50207237
@jerryshao I'll just merge this as is for now, seems simpler.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1210
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1210#issuecomment-49973939
QA results for PR 1210:br- This patch PASSES unit tests.brbrFor more
information see test
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1210#issuecomment-49974441
QA tests have started for PR 1210. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17108/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1210#issuecomment-49977441
QA results for PR 1210:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1210#issuecomment-49845379
Sorry for the delay -- yeah, try adding that for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/1210#issuecomment-49865582
Hi Matei, should I wait until your sort-based shuffle is merged into master
branch, so I change the current in memory sort to external sort?
---
If your project is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1210#issuecomment-49968795
QA tests have started for PR 1210. This patch DID NOT merge cleanly!
brView progress:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1210#issuecomment-49293649
QA results for PR 1210:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1210#discussion_r15093320
--- Diff:
core/src/main/scala/org/apache/spark/rdd/OrderedRDDFunctions.scala ---
@@ -57,14 +57,13 @@ class OrderedRDDFunctions[K : Ordering : ClassTag,
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1210#discussion_r15093402
--- Diff:
core/src/main/scala/org/apache/spark/rdd/OrderedRDDFunctions.scala ---
@@ -57,14 +57,13 @@ class OrderedRDDFunctions[K : Ordering : ClassTag,
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1210#issuecomment-49385778
@scrapcodes @pwendell there's a MIMA error on this that seems spurious: it
complains that `synthetic method
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/1210#discussion_r15093470
--- Diff:
core/src/main/scala/org/apache/spark/rdd/OrderedRDDFunctions.scala ---
@@ -57,14 +57,13 @@ class OrderedRDDFunctions[K : Ordering : ClassTag,
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/1210#issuecomment-49386693
Shall we add this
```
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1210#issuecomment-49387221
QA tests have started for PR 1210. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16801/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1210#issuecomment-49391815
QA results for PR 1210:br- This patch FAILED unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1210#issuecomment-49254626
@jerryshao after looking more at #931, I'd actually like to hold off on
merging that the way it's set up, so would you mind updating this now? I can
merge this as is
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/1210#issuecomment-48859519
Hi Matei, thanks a lot for your review, I will change the code according to
your comments.
---
If your project is set up for it, you can reply to this email and have
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1210#issuecomment-48818275
This looks pretty good to me API-wise, but an Option[Boolean] is kind of
confusing. Maybe we should have an enumeration called SortOrder and pass in an
Option[SortOrder].
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/1210#issuecomment-48433693
I'm not sure is that what you want, so I hope you can review it and give me
come comments. Thanks a lot.
---
If your project is set up for it, you can reply to this
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1210#issuecomment-48426441
Sorry for the delay, Saisai -- will take a look soon. I've been away
traveling this week.
---
If your project is set up for it, you can reply to this email and have your
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/1210#issuecomment-48174580
Hi @mateiz, mind taking a look at this PR, thanks a lot.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user jerryshao opened a pull request:
https://github.com/apache/spark/pull/1210
[SPARK-2125] Add sort flag and move sort into shuffle implementations
This patch adds a sort flag into ShuffleDependecy and moves sort into hash
shuffle implementation.
Moving sort into
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1210#issuecomment-47075231
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1210#issuecomment-47075220
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user witgo commented on a diff in the pull request:
https://github.com/apache/spark/pull/1210#discussion_r14174587
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/HashShuffleReader.scala ---
@@ -49,6 +49,17 @@ class HashShuffleReader[K, C](
} else {
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/1210#discussion_r14174925
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/hash/HashShuffleReader.scala ---
@@ -49,6 +49,17 @@ class HashShuffleReader[K, C](
} else {
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1210#issuecomment-47086129
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1210#issuecomment-47086130
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16113/
---
If your project is set up for it, you can
29 matches
Mail list logo
