Github user manishamde commented on the pull request:
https://github.com/apache/spark/pull/1316#issuecomment-48506335
Thanks @mengxr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user johnnywalleye commented on the pull request:
https://github.com/apache/spark/pull/1316#issuecomment-48326815
Sure, updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user manishamde commented on the pull request:
https://github.com/apache/spark/pull/1316#issuecomment-48404544
@johnnywalleye I will review this PR and get back soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user johnnywalleye commented on the pull request:
https://github.com/apache/spark/pull/1316#issuecomment-48406001
Great, thanks!
On Tue, Jul 8, 2014 at 5:56 PM, manishamde notificati...@github.com wrote:
@johnnywalleye https://github.com/johnnywalleye I
Github user manishamde commented on the pull request:
https://github.com/apache/spark/pull/1316#issuecomment-48409180
LGTM! The classic off-by-one error gets you no matter how much attention
you pay. Thanks for the rigorous review.
@pwendell Could we also add this 1.0 patch
Github user manishamde commented on the pull request:
https://github.com/apache/spark/pull/1316#issuecomment-48414923
@johnnywalleye Nevermind. I fixed the same error on the multiclass PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1316
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/1316#issuecomment-48422865
Thanks @johnnywalleye for the fix and @manishamde for reviewing the PR! I
merged it into both master and branch-1.0, but I'm not sure whether it can make
into v1.0.1 . I
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/1316#issuecomment-48422871
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
